fix: PhotosViewController shouldn’t retain its data source

This would lead too easily to difficult-to-manage retain cycles.
popei69 · Feb 2, 2017 · bdf5fe0 · bdf5fe0
1 parent 18b5296
commit bdf5fe0
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/NYTPhotoViewer/NYTPhotosViewController.h b/NYTPhotoViewer/NYTPhotosViewController.h
@@ -58,10 +58,8 @@ extern NSString * const NYTPhotosViewControllerDidDismissNotification;
  *  The data source underlying this PhotosViewController.
  *
  *  After setting a new data source, you must call `-reloadPhotosAnimated:`.
- *
- *  The data source is retained (unlike UITableView's data source).
  */
-@property (nonatomic) id <NYTPhotoViewerDataSource> dataSource;
+@property (nonatomic, weak, nullable) id <NYTPhotoViewerDataSource> dataSource;
 
 /**
  *  The object conforming to `NYTPhoto` that is currently being displayed by the `pageViewController`.