smbd: Make parent_override_delete a bit more readable

Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
portalarchitects · Aug 6, 2024 · 95c031b · 95c031b
1 parent 8353770
commit 95c031b
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/source3/smbd/open.c b/source3/smbd/open.c
@@ -85,14 +85,12 @@ static bool parent_override_delete(connection_struct *conn,
 					uint32_t access_mask,
 					uint32_t rejected_mask)
 {
-	if ((access_mask & DELETE_ACCESS) &&
-		    (rejected_mask & DELETE_ACCESS) &&
-		    can_delete_file_in_directory(conn,
-				dirfsp,
-				smb_fname))
-	{
-		return true;
+	if ((access_mask & DELETE_ACCESS) && (rejected_mask & DELETE_ACCESS)) {
+		bool ok;
+		ok = can_delete_file_in_directory(conn, dirfsp, smb_fname);
+		return ok;
 	}
+
 	return false;
 }