Added different modulations in signal generator

[daviderud]

Added DSB, AM 100% mod index and AM 50% mod index. Changed UI.

[gullradriel]

Hello @daviderud .
Thanks for the contributions.
Please apply proper formatting by running format-code.sh at the root of your clone. Commit the changes so the checks can pass.

[gullradriel]

proc_siggen.cpp is not correctly formatted.
Maybe you forgot to commit after caller format-code.sh ?

[daviderud]

For some reason VS Code in windows do not perform any format correction in the proc_siggen.cpp . Had to run the sh script on a linux virtual machine...
I will try to see if I manage to add the clang in the docker so that the script can be run from there in Windows.

[gullradriel]

I relaunched the checks, we will see if all is good :-)

[gullradriel]

Looks good to me, thanks !

[gullradriel]

I think we are going to bypass firmware limits with that PR.
Please wait a bit that we externalize one or two more apps before we merge.

[daviderud]

Too many nice features thanks to you guys. No hurry at all. Cheers, Davide

…

________________________________ From: gullradriel ***@***.***> Sent: Sunday, January 26, 2025 11:52:59 AM To: portapack-mayhem/mayhem-firmware ***@***.***> Cc: Davide Rovelli ***@***.***>; Mention ***@***.***> Subject: Re: [portapack-mayhem/mayhem-firmware] Added different modulations in signal generator (PR #2492) I think we are going to bypass firmware limits with that PR. Please wait a bit that we externalize one or two more apps before we merge. — Reply to this email directly, view it on GitHub<#2492 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYTC25J36WQ2GS3ZONYIWSL2MS5AXAVCNFSM6AAAAABV3NWKF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGMZDGMZSGE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[voxo22]

@daviderud Many thanks for this excellent feature! Awesome, dude. Do you think it will be possible to add AM modulation switch also to Morse app and to Soundboard app?
By the way, I think there is no useful Signal Generator program for Hack RF anywhere (not including Portapack), except maybe GNU radio, but... you know... That's why the Signal generator app is more than useful in Portapack, it's very handy.
What I would welcome so much is also pulse generator, which is definitively missing. Do you think you can improve Signal Generator with pulse generator feature? I will log it as a new enhancement issue.
Thanks!

[voxo22]

#2505

[daviderud]

@daviderud Many thanks for this excellent feature! Awesome, dude. Do you think it will be possible to add AM modulation switch also to Morse app and to Soundboard app? By the way, I think there is no useful Signal Generator program for Hack RF anywhere (not including Portapack), except maybe GNU radio, but... you know... That's why the Signal generator app is more than useful in Portapack, it's very handy. What I would welcome so much is also pulse generator, which is definitively missing. Do you think you can improve Signal Generator with pulse generator feature? I will log it as a new enhancement issue. Thanks!

Hi, thanks for the message.

With the Hack RF in HackRF mode you can use the SDRAngel freeware on the computer to have a GUI that allows you to configure the transmitter in many modes including morse keying.

With just the portapack would be easier the setup. So far I studied the code of the signal generator and not the one of the other apps, so can't tell how easy is to include the modification also there. In principle there could be just one signal generator that performs the modulation of math functions, mic, or wave, but this is would be a wide modification I guess.

The pulse generation might be easy to do in the signal gen maybe adding some code like the BPSK, but with half of the period with no signal generation and half with signal. Not sure it is what you are after.

Cheers

[voxo22]

@daviderud Hi,
please look at issue #2505 and tell me, if you can make something like that.
I mean, 50% duty cycle pulse generator is not exactly, what I want, I prefer to have just single pulse generator with variable pulse width, launched with START button. And then some other variable for the pause width + "loop" checkbox. CW modulation. That's it. Purpose: I often check broadband meters time response and also spectrum analyzer sweep speed. Then I need to generate e.g. pulse with 10 µs duration and see, if the meter or analyzer correctly detected.