Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when parsing text emails #34

Closed
wants to merge 1 commit into from

Conversation

snowl
Copy link

@snowl snowl commented Apr 5, 2024

When parsing a text email, there is a scenario where the ArrayBuffer needs to be initialized from scratch instaed from the readable stream. We need to use new ArrayBuffer instead of just ArrayBuffer otherwise an exception is thrown.

image

(Sorry for the minified image)

When parsing a text email, there is a scenario where the ArrayBuffer needs to be initialized from scratch instaed from the readable stream. We need to use `new ArrayBuffer` instead of just `ArrayBuffer` otherwise an exception is thrown.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@andris9
Copy link
Contributor

andris9 commented Apr 5, 2024

Thanks for noticing. I can't accept PRs without a CLA. If you are not willing to sign it (see the comment above), then let me know, and I'll fix the bug myself.

@andris9
Copy link
Contributor

andris9 commented Apr 10, 2024

Closing as I can not merge without a CLA. Fixed the issue in v2.2.2 myself.

@andris9 andris9 closed this Apr 10, 2024
@snowl
Copy link
Author

snowl commented Apr 11, 2024

Sorry, I didn't see your comments. Thank you for fixing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants