Simple Counter without auth #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happyhappy-jun
requested changes
Jul 12, 2022
simple-counter/src/lib.rs
Outdated
| pub fn increment(&mut self) { | ||
| //let caller = env::signer_account_id(); | ||
| //use below line instead of below for test | ||
| let caller = "kmlee".to_string(); |
There was a problem hiding this comment.
caller 가 어떠한 임의의 계정으로 고정이 되어있습니다
simple-counter/src/lib.rs
Outdated
| let caller = "kmlee".to_string(); | ||
| let current_val = match self.user_counters.get(&caller) { //get previous value | ||
| Some(val) => val, | ||
| None => 0i16 |
There was a problem hiding this comment.
get을 했는데, 어떠한 값도 찾을 수 없다면, 0을 리턴하는 게 좋을까요? 아니면, panic 으로 터트리는게 더 좋을까요?
만약에 존재하지 않는 계정을 increase 하려고 하면 뭐가 문제일지 함수 명과 함께 생각해봅니다
simple-counter/src/lib.rs
Outdated
| let caller = "kmlee".to_string(); | ||
| let current_val = match self.user_counters.get(&caller) { //get previous value | ||
| Some(val) => val, | ||
| None => 0i16 |
There was a problem hiding this comment.
위 코멘트와 비슷한 맥락이지만, 이쪽은 더 위험합니다. 다행히 지금은 자료형이 i16 signed 이지만, u64에서는 무슨 일이 벌어질까요?
There was a problem hiding this comment.
자료형을 수정하고 이 또한 decrease 함수 또한 panic으로 수정했습니다
| //logging | ||
| env::log(b"Reset counter to zero"); | ||
| } | ||
| pub fn delete(&mut self, k: String) { |
previously function upload_modify_and_query have to deploy, interact with smart contract. Now, changed to simply interact with pre-deployed contract.
since two features are tested in single test, split it into seperate tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of this PR
Describe your changes
Using UnordereMap to generate simple counter without auth
Used designated account name(kmlee) for test
Reference
https://github.com/near-examples/rust-status-message/blob/master/src/lib.rs
https://github.com/near-examples/rust-counter/blob/01-use-hashmap/contract/src/lib.rs
https://www.near-sdk.io/testing/unit-tests
Issue ticket number and other helpful resource
Checklist before requesting a review
Checklist after creating a pull request