Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Neg for FieldElement. #2252

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Implement Neg for FieldElement. #2252

merged 2 commits into from
Dec 18, 2024

Conversation

chriseth
Copy link
Member

No description provided.

Schaeff
Schaeff reviewed Dec 18, 2024
View reviewed changes
executor/src/witgen/jit/compiler.rs Outdated
#[inline]
fn neg(self) -> Self {{
if self.0 == 0 {{
Self(0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not self?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point :)

@georgwiese georgwiese added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit a3d9f38 Dec 18, 2024
16 checks passed
@georgwiese georgwiese deleted the neg_for_fe branch December 18, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schaeff Schaeff Schaeff left review comments

@georgwiese georgwiese georgwiese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriseth @georgwiese @Schaeff