phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate

The of_xlate callback should return ERR_PTR on error. Signed-off-by: Axel Lin <[email protected]> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
powerwareeasyman · Apr 3, 2015 · 247e21c · 247e21c
1 parent fbea230
commit 247e21c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c
@@ -192,14 +192,14 @@ static struct phy *spear1310_miphy_xlate(struct device *dev,
 
 	if (args->args_count < 1) {
 		dev_err(dev, "DT did not pass correct no of args\n");
-		return NULL;
+		return ERR_PTR(-ENODEV);
 	}
 
 	priv->mode = args->args[0];
 
 	if (priv->mode != SATA && priv->mode != PCIE) {
 		dev_err(dev, "DT did not pass correct phy mode\n");
-		return NULL;
+		return ERR_PTR(-ENODEV);
 	}
 
 	return priv->phy;