minimum signature time not checked, more params validation in ESOP

contracts/ESOP.sol

@@ -148,19 +148,19 @@ contract ESOP is ESOPTypes, CodeUpdateable, TimeSource {
     }
   }
 
-  function openESOP(uint32 ptotalPoolOptions, bytes pESOPLegalWrapperIPFSHash)
+  function openESOP(uint32 pTotalPoolOptions, bytes pESOPLegalWrapperIPFSHash)
     external
     onlyCompany
     onlyESOPNew
     isCurrentCode
     returns (ReturnCodes)
   {
     // options are stored in unit32
-    if (ptotalPoolOptions > 1100000) {
+    if (pTotalPoolOptions > 1100000 || pTotalPoolOptions < 10000) {
       return _logerror(ReturnCodes.InvalidParameters);
     }
 
-    totalPoolOptions = ptotalPoolOptions;
+    totalPoolOptions = pTotalPoolOptions;
     remainingPoolOptions = totalPoolOptions;
     ESOPLegalWrapperIPFSHash = pESOPLegalWrapperIPFSHash;
 
@@ -189,7 +189,7 @@ contract ESOP is ESOPTypes, CodeUpdateable, TimeSource {
       removeEmployeesWithExpiredSignaturesAndReturnFadeout();
     }
     uint poolOptions = optionsCalculator.calcNewEmployeePoolOptions(remainingPoolOptions);
-    if (poolOptions > 0xFFFFFFFF || poolOptions == 0)
+    if (poolOptions > 0xFFFFFFFF)
       throw;
     Employee memory emp = Employee({
       issueDate: issueDate, timeToSign: timeToSign, terminatedAt: 0, fadeoutStarts: 0, poolOptions: uint32(poolOptions),
@@ -217,6 +217,9 @@ contract ESOP is ESOPTypes, CodeUpdateable, TimeSource {
     if (employees.hasEmployee(e)) {
       return _logerror(ReturnCodes.InvalidEmployeeState);
     }
+    if (timeToSign < currentTime() + MINIMUM_MANUAL_SIGN_PERIOD) {
+      return _logerror(ReturnCodes.TooLate);
+    }
     Employee memory emp = Employee({
       issueDate: issueDate, timeToSign: timeToSign, terminatedAt: 0, fadeoutStarts: 0, poolOptions: 0,
       extraOptions: extraOptions, suspendedAt: 0, state: EmployeeState.WaitingForSignature, idx: 0