Escape parentheses in filenames (mattijs#41)

* Escape parentheses in filenames * Fix formatting
pppp606 · Sep 11, 2016 · c03e554 · c03e554
1 parent dc845e5
commit c03e554
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/rsync.js b/rsync.js
@@ -832,7 +832,7 @@ function escapeShellArg(arg) {
  * @return {String} the escaped version of the filename
  */
 function escapeFileArg(filename) {
-  return filename.replace(/(["'`\s\\])/g,'\\$1');
+  return filename.replace(/(["'`\s\\\(\)])/g,'\\$1');
 }
 
 /**

diff --git a/tests/input.test.js b/tests/input.test.js
@@ -50,6 +50,14 @@ describe('input', function () {
           assertOutputPattern(rsync, / a_quoted\\'filename\\".txt /);
       });
 
+      it('should have parentheses escaped', function () {
+          rsync = Rsync.build({
+              source:       [ 'a (file) with parantheses.txt' ],
+              destination:  'themoon'
+          });
+          assertOutputPattern(rsync, /a\\ \\\(file\\\)\\ with\\ parantheses.txt/);
+      });
+
       it('should allow mixed filenames', function () {
           rsync = Rsync.build({
               source: [