[FLINK-33546] Implement type inference for order(asc/desc) function

This closes apache#23733
pppsunil · Nov 16, 2023 · 54906fe · 54906fe
1 parent 6101b67
commit 54906fe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 53 deletions.
diff --git a/...ble-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java b/...ble-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
@@ -2005,14 +2005,16 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
             BuiltInFunctionDefinition.newBuilder()
                     .name("asc")
                     .kind(OTHER)
-                    .outputTypeStrategy(TypeStrategies.MISSING)
+                    .inputTypeStrategy(sequence(ANY))
+                    .outputTypeStrategy(argument(0))
                     .build();
 
     public static final BuiltInFunctionDefinition ORDER_DESC =
             BuiltInFunctionDefinition.newBuilder()
                     .name("desc")
                     .kind(OTHER)
-                    .outputTypeStrategy(TypeStrategies.MISSING)
+                    .inputTypeStrategy(sequence(ANY))
+                    .outputTypeStrategy(argument(0))
                     .build();
 
     // --------------------------------------------------------------------------------------------

diff --git a/...rc/main/scala/org/apache/flink/table/planner/expressions/PlannerExpressionConverter.scala b/...rc/main/scala/org/apache/flink/table/planner/expressions/PlannerExpressionConverter.scala
@@ -117,14 +117,6 @@ class PlannerExpressionConverter private extends ApiExpressionVisitor[PlannerExp
       case fd: FunctionDefinition =>
         fd match {
 
-          case ORDER_ASC =>
-            assert(args.size == 1)
-            Asc(args.head)
-
-          case ORDER_DESC =>
-            assert(args.size == 1)
-            Desc(args.head)
-
           case OVER =>
             assert(args.size >= 4)
             OverCall(

diff --git a/...nk-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/ordering.scala b/...nk-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/ordering.scala