Remove last vestiges of gscoped_ptr

Adar did most of the work here a few months back. This changes the last usages of gscoped_array over to unique_ptr<T[]> and removes gscoped_ptr entirely from the code base. May it rest in peace. Change-Id: I03832c310b5804227abf35f58aa320e5e81151f6 Reviewed-on: http://gerrit.cloudera.org:8080/16261 Reviewed-by: Adar Lieber-Dembo <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins
prabhav-thali · Jul 31, 2020 · 4f7b1aa · 4f7b1aa
1 parent 924244c
commit 4f7b1aa
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 873 deletions.
diff --git a/build-support/release/rat_exclude_files.txt b/build-support/release/rat_exclude_files.txt
@@ -62,7 +62,6 @@ src/kudu/gutil/cpu.cc
 src/kudu/gutil/cpu.h
 src/kudu/gutil/dynamic_annotations.c
 src/kudu/gutil/dynamic_annotations.h
-src/kudu/gutil/gscoped_ptr.h
 src/kudu/gutil/int128.cc
 src/kudu/gutil/int128.h
 src/kudu/gutil/integral_types.h

diff --git a/docs/contributing.adoc b/docs/contributing.adoc
@@ -247,12 +247,6 @@ as in the following example.
   }
 ----
 
-NOTE: Older parts of the Kudu code base use `gscoped_ptr` instead of
-`unique_ptr`. These are hold-overs from before Kudu adopted {cpp}11.
-New code should not use `gscoped_ptr` except when necessary to interface
-with existing code. Alternatively, consider updating usages as you come
-across them.
-
 WARNING: Using `std::auto_ptr` is strictly disallowed because of its difficult and
 bug-prone semantics. Besides, `std::auto_ptr` is declared deprecated
 since {cpp}11.