Improvement (jainaman224#70)

pranayberry · Jul 10, 2016 · 12182d9 · 12182d9
1 parent 6137352
commit 12182d9
Show file tree

Hide file tree

Showing 16 changed files with 90 additions and 83 deletions.
diff --git a/Binary_Search/Binary_Search.cs b/Binary_Search/Binary_Search.cs
@@ -1,14 +1,14 @@
 using System;
 
-//The namespace refers to the project name you are working on.
+// The namespace refers to the project name you are working on.
 namespace BinarySearch
 {
     class Program
     {
         public static int Binary_Search(int[] array, int size, int desired)
         {
             int left = 0, right = size - 1, middle;
-            while(left<=right)
+            while(left <= right)
             {
                 middle = left + (right - left) / 2;
                 if(array[middle] == desired)
@@ -28,19 +28,20 @@ static void Main(string[] args)
                 Console.WriteLine("Found");
             else
                 Console.WriteLine("Not Found");
-            //Element 9 to be searched
+            // Element 9 to be searched
             if(Binary_Search(array, 7, 9) != -1)
                 Console.WriteLine("Found");
             else
                 Console.WriteLine("Not Found");
             Console.WriteLine();
-            Console.ReadLine(); //To hold output (optional)
+            Console.ReadLine(); // To hold output (optional)
         }
     }
 }
 
-/*
-output:
+/* Output
+
 Found
 Not Found
+
 */
diff --git a/Bubble_Sort/Bubble_Sort.cs b/Bubble_Sort/Bubble_Sort.cs
@@ -4,7 +4,7 @@ namespace Bubble_Sort
 {
     class Program
     {
-        // function for bubble sort
+        // Function for bubble sort
         public static void BubbleSort(int[] array, int size)
         {
             int temp;
@@ -24,7 +24,7 @@ public static void BubbleSort(int[] array, int size)
 
         }
 
-        // function to print array
+        // Function to print array
         public static void Print_Array(int[] array, int size)
         {
             for(int i = 0; i < size; i++)

diff --git a/Chinese_Remainder_Theorem/Chinese_Remainder_Theorem.cs b/Chinese_Remainder_Theorem/Chinese_Remainder_Theorem.cs
@@ -35,12 +35,12 @@ public static int findMinimumDividend(int[] divisor, int[] remainder)
             int i, result, partialProduct;
             int len = divisor.GetLength(0);
 
-            for(i=0; i<len; i++)
+            for(i = 0; i < len; i++)
                 product *= divisor[i];
 
             result = 0;
 
-            for(i=0; i<len; i++)
+            for(i = 0; i < len; i++)
             {
                 partialProduct = product / divisor[i];
                 result += remainder[i] * inverse(partialProduct, divisor[i]) * partialProduct;
@@ -59,5 +59,6 @@ static void Main(String[] args)
         }
     }
 }
-//Output
-//Minimum value of dividend is : 3371
+
+// Output
+// Minimum value of dividend is : 3371
diff --git a/Counting_Sort/Counting_Sort.cs b/Counting_Sort/Counting_Sort.cs
@@ -41,8 +41,8 @@ public static void CountingSort(int[] input)
             for(int i = 0; i < n; i++)
                 input[i] = output[i]; // Copy the output array to input, so that input now contains sorted values
         }
-        // function for bubble sort
-        // function ro print array
+        // Function for bubble sort
+        // Function ro print array
         public static void Print_Array(int[] array, int size)
         {
             for(int i = 0; i < size; i++)

diff --git a/Euclidean_Algorithm/Euclidean_Algorithm.cs b/Euclidean_Algorithm/Euclidean_Algorithm.cs
@@ -12,28 +12,29 @@ public static int EuclidGCD(int a, int b)
                 return EuclidGCD(b, a % b);
         }
 
-       public static void Main (String[] args)
-	     {
-		       int	a = 315;
-		       int	b = 105;
-		       int	c = EuclidGCD(a,b);
-		       Console.WriteLine(c);
-          // prints 105
-          // GCD of 315 and 105 is 105
-           a = 30;
-           b = 105;
-           c = EuclidGCD(a,b);
-           Console.WriteLine(c);
-		      // prints 15
-          // GCD of 30 and 105 is 15
-           Console.WriteLine();
-           Console.ReadLine();
-	     }
-   }
+        public static void Main(String[] args)
+	    {
+		    int	a = 315;
+		    int	b = 105;
+		    int	c = EuclidGCD(a, b);
+		    Console.WriteLine(c);
+            // Prints 105
+            // GCD of 315 and 105 is 105
+            a = 30;
+            b = 105;
+            c = EuclidGCD(a, b);
+            Console.WriteLine(c);
+		    // Prints 15
+            // GCD of 30 and 105 is 15
+            Console.WriteLine();
+            Console.ReadLine();
+	    }
+    }
 }
 
-/*
-Output:
-  105
-  15
+/* Output
+
+105
+15
+
 */
diff --git a/Extended_Euclidean_Algorithm/Extended_Euclidean_Algorithm.cs b/Extended_Euclidean_Algorithm/Extended_Euclidean_Algorithm.cs
@@ -15,7 +15,7 @@ public static int gcdFunction(int a, int b, int x, int y)
             int x1 = 0;
             int y1 = 0;
             int gcd = gcdFunction(b % a, a, x1, y1);
-            x = y1 - b / a * x1;
+            x = y1 - (b / a) * x1;
             y = x1;
             return gcd;
         }
@@ -34,5 +34,5 @@ public static void Main(String[] args)
     }
 }
 
-//output
-//GCD of numbers 98 and 21 is 7
+// Output
+// GCD of numbers 98 and 21 is 7
diff --git a/Heap_Sort/Heap_Sort.cs b/Heap_Sort/Heap_Sort.cs
@@ -48,7 +48,7 @@ public static void HeapSort(int[] array, int size)
             }
         }
 
-        // function ro print array
+        // Function ro print array
         public static void Print_Array(int[] array, int size)
         {
             for(int i = 0; i < size; i++)
@@ -67,5 +67,5 @@ public static void Main(String[] args)
     }
 }
 
-//output
+// Output
 // 1 2 3 4 4 6 8
diff --git a/Insertion_Sort/Insertion_Sort.cs b/Insertion_Sort/Insertion_Sort.cs
@@ -4,7 +4,7 @@ namespace Insertion_Sort
 {
     class Program
     {
-        // function for insertion sort
+        // Function for insertion sort
         public static void InsertionSort(int[] array, int size)
         {
             int temp, j;
@@ -22,7 +22,7 @@ public static void InsertionSort(int[] array, int size)
             }
         }
 
-        // function to print array
+        // Function to print array
         public static void Print_Array(int[] array, int size)
         {
             for(int i = 0; i < size; i++)

diff --git a/Interpolation_Search/Interpolation_Search.cs b/Interpolation_Search/Interpolation_Search.cs
@@ -6,7 +6,7 @@ class Program
     {
         public static int interpolation(int[] a, int n, int search_item) // Function implementing Interpolation_Search
         {
-            int high = n-1;
+            int high = n - 1;
             int low = 0;
             int pos;
 
@@ -44,7 +44,8 @@ public static void Main(String[] args)
     }
 }
 
-/*
-Output:
-Found at position7
+/* Output
+
+Found at position 7
+
 */
diff --git a/Kadane_Algorithm/Kadane_Algorithm.cs b/Kadane_Algorithm/Kadane_Algorithm.cs
@@ -11,7 +11,8 @@ public static int max(int a, int b)
             else
                 return b;
         }
-        // function implementing Kadane's Algorithm (array contains at least one positive number)
+
+        // Function implementing Kadane's Algorithm (array contains at least one positive number)
         public static int kadane(int[] input, int size)
         {
             int current_max = 0;
@@ -22,41 +23,42 @@ public static int kadane(int[] input, int size)
                 current_max = max(0, current_max + input[i]);
                 max_so_far = max(max_so_far, current_max);
             }
-            return max_so_far;// maximum subarray sum
+            return max_so_far; // Maximum subarray sum
         }
 
         static void Main(String[] args)
         {
             int size, max_subarray_sum;
 
-            int[] input = { -2, 1, -6, 4, -1, 2, 1, -5, 4 }; //input array
+            int[] input = { -2, 1, -6, 4, -1, 2, 1, -5, 4 }; // Input array
 
-            size = 9;//size of array
+            size = 9; // Size of array
 
-            int flag = 0;//flag variable to check if all the numbers in array are negative or not
+            int flag = 0; // Flag variable to check if all the numbers in array are negative or not
 
-            int largest_in_negative = input[0];//smallest_negative variable will store the maximum subarray sum if all the numbers are negative in array
+            int largest_in_negative = input[0]; // Smallest_negative variable will store the maximum subarray sum if all the numbers are negative in array
 
-            for(int i = 0; i < size; i++) // scanning each element in array
+            for(int i = 0; i < size; i++) // Scanning each element in array
             {
-                  if(input[i] >= 0)// if any element is positive, kadane's algo can be applied
+                  if(input[i] >= 0) // If any element is positive, kadane's algo can be applied
                   {
                       flag = 1;
                       break;
                   }
-                  else if(input[i] > largest_in_negative) // if all the elements are negative, find the largest in them
+                  else if(input[i] > largest_in_negative) // If all the elements are negative, find the largest in them
                       largest_in_negative = input[i];
             }
 
-            if(flag == 1)// kadane's algo applicable
+            if(flag == 1) // Kadane's algo applicable
                 max_subarray_sum = kadane(input, size);
             else
-                max_subarray_sum = largest_in_negative;// kadane 's algo not applicable,
-            //hence the max_subarray_sum will be the largest number in array itself
-            Console.WriteLine("Maximum Subarray Sum is "+ Convert.ToString(max_subarray_sum));
+                max_subarray_sum = largest_in_negative; // Kadane 's algo not applicable,
+            // hence the max_subarray_sum will be the largest number in array itself
+            Console.WriteLine("Maximum Subarray Sum is " + Convert.ToString(max_subarray_sum));
             Console.ReadLine();
         }
     }
 }
 
-//output : Maximum Subarray Sum is 6
+// Output
+// Maximum Subarray Sum is 6
diff --git a/Knuth_Morris_Pratt_Algorithm/KMP.cs b/Knuth_Morris_Pratt_Algorithm/KMP.cs
@@ -6,7 +6,7 @@ class Program
     {
         public static void calculateLps(string pattern, int[] lps)
         {
-            int length = 0;  // Length of the previous longest prefix suffix
+            int length = 0; // Length of the previous longest prefix suffix
             int i;
 
             lps[0] = 0;

diff --git a/Linear_Search/Linear_Search.cs b/Linear_Search/Linear_Search.cs
@@ -8,7 +8,7 @@ public static int LinearSearch(int[] array, int size, int desired)
         {
             for (int i = 0; i < size; i++)
             {
-                // return position if element is found
+                // Return position if element is found
                 if (array[i] == desired)
                     return i;
             }
@@ -27,7 +27,7 @@ public static void Main(String[] args)
             else
                 Console.WriteLine("Not Found");
 
-        //Element 9 to be searched
+            // Element 9 to be searched
             if(LinearSearch(array, 7, 9) != -1)
                 Console.WriteLine("Found");
             else
@@ -37,8 +37,9 @@ public static void Main(String[] args)
     }
 }
 
-/*
-Output:
+/* Output
+
 Found
 Not Found
+
 */
diff --git a/Naive_String_Matching/Naive_Approach.cpp b/Naive_String_Matching/Naive_Approach.cpp
@@ -16,7 +16,7 @@ void search(string text, string pattern)
                 break;
 
         if(j == lengthPattern)
-           cout << "Pattern found at " << i << endl;
+           cout << "Pattern found at " << i + 1 << endl;
     }
 }
 
@@ -30,8 +30,8 @@ int main()
 
 /* Output
 
-Pattern found at 1
-Pattern found at 7
-Pattern found at 16
+Pattern found at 2
+Pattern found at 8
+Pattern found at 17
 
 */
diff --git a/Naive_String_Matching/Naive_Approach.java b/Naive_String_Matching/Naive_Approach.java
@@ -1,4 +1,4 @@
-class Naive_Approach
+class Main
 {
     public static void search(String text, String pattern)
     {
@@ -14,7 +14,7 @@ public static void search(String text, String pattern)
                     break;
 
             if(j == lengthPattern)
-               System.out.println("Pattern found at " + i);
+               System.out.println("Pattern found at " + (i + 1));
         }
     }
 
@@ -28,8 +28,8 @@ public static void main(String[] args)
 
 /* Output
 
-Pattern found at 1
-Pattern found at 7
-Pattern found at 16
+Pattern found at 2
+Pattern found at 8
+Pattern found at 17
 
 */
diff --git a/Naive_String_Matching/Naive_Approach.py b/Naive_String_Matching/Naive_Approach.py
@@ -12,16 +12,16 @@ def search(text, pattern):
             j += 1
 
         if j == lengthPattern:
-            print("Pattern found at " + str(i))
+            print("Pattern found at " + str(i + 1))
 
 text = "namanchamanbomanamansanam"
 pattern = "aman"
 search(text, pattern)
 
 ''' Output
 
-Pattern found at 1
-Pattern found at 7
-Pattern found at 16
+Pattern found at 2
+Pattern found at 8
+Pattern found at 17
 
 '''