Skip to content

Commit

Permalink
remote: bring back manual close_pools()
Browse files Browse the repository at this point in the history
We used to have this line previously, thinking that it was only a py2
issue, but it turned out that it happens on py3 as well. So bring this
line back for now.
  • Loading branch information
efiop committed Feb 2, 2020
1 parent 945a517 commit 06ca3b7
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions dvc/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from dvc.external_repo import clean_repos
from dvc.logger import FOOTER
from dvc.utils import format_link
from dvc.remote.pool import close_pools

# Workaround for CPython bug. See [1] and [2] for more info.
# [1] https://github.com/aws/aws-cli/blob/1.16.277/awscli/clidriver.py#L55
Expand Down Expand Up @@ -73,6 +74,11 @@ def main(argv=None):
finally:
logger.setLevel(outerLogLevel)

# Closing pools by-hand to prevent wierd messages when closing SSH
# connections. See https://github.com/iterative/dvc/issues/3248 for
# more info.
close_pools()

# Remove cached repos in the end of the call, these are anonymous
# so won't be reused by any other subsequent run anyway.
clean_repos()
Expand Down

0 comments on commit 06ca3b7

Please sign in to comment.