refactor: Remove declare global from internal types
#4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: 0 B Total Size: 62.5 kB ℹ️ View Unchanged
|
rschristian
commented
Nov 29, 2024
Comment on lines
+1
to
+6
| import { | ||
| Options as PreactOptions, | ||
| Component as PreactComponent, | ||
| VNode as PreactVNode, | ||
| Context as PreactContext, | ||
| } from '../../src/internal'; |
marvinhagemeister
approved these changes
Nov 29, 2024
|
Nice, the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4173 introduced
declare globalto skip having to import them insrc/. However, this blocks usage in other repos (like devtools, which needed to patch this) and we're really abusing the language server to support it. From a TS file you would not be able to import interfaces declared withindeclare global {}, it blocks all use. While it "works" for our JS usage (every subpath imports fromsrc/internal) at the moment, we have a bunch of TS issues that I'm trying to track down and I don't think this is helping matters one bit.It's also just really ambiguous. If we're going to have multiple
VNode,Component, etc. definitions sitting around, let's at least point to which one we're referencing, no?