Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct defaultValue property types for inputs, selects, & textareas #4585

Merged
merged 3 commits into from
Nov 30, 2024
Merged

fix: Correct defaultValue property types for inputs, selects, & textareas #4585

merged 3 commits into from
Nov 30, 2024

Conversation

rschristian
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Nov 30, 2024 •
edited
Loading

Coverage Status

coverage: 99.617%. remained the same
when pulling 7097d4f on types/textarea-defaultvalue
into 42e7b45 on main.

@rschristian rschristian changed the title fix: Add defaultValue property to textareas fix: Add defaultValue property to textareas & selects Nov 30, 2024
@rschristian rschristian changed the title fix: Add defaultValue property to textareas & selects fix: Add defaultValue property type to textareas & selects Nov 30, 2024
@rschristian rschristian changed the title fix: Add defaultValue property type to textareas & selects fix: Correct defaultValue property types for inputs, selects, & textareas Nov 30, 2024
rschristian
rschristian commented Nov 30, 2024
View reviewed changes
src/jsx.d.ts
defaultValue?: Signalish<string | undefined>;
defaultValue?: Signalish<string | number | undefined>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported in our old types, but I think it should be? Nothing wrong with input.defaultValue = 2.

@JoviDeCroock JoviDeCroock merged commit 42524db into main Nov 30, 2024
5 checks passed
@JoviDeCroock JoviDeCroock deleted the types/textarea-defaultvalue branch November 30, 2024 04:28
@JoviDeCroock JoviDeCroock mentioned this pull request Dec 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschristian @coveralls @JoviDeCroock