chore: Correct some internal test types #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
commented
Nov 30, 2024
| @@ -37,7 +37,6 @@ | |||
| "$_args": "__H", | |||
| "$_factory": "__h", | |||
| "$_depth": "__b", | |||
| "$_nextDom": "__d", | |||
There was a problem hiding this comment.
We should be able to remove post #4553, no?
Comment on lines
-239
to
-253
| /** @type {(vnode: import('../../src/internal').VNode) => void} */ | ||
| function verifyVNodeTree(vnode) { | ||
| if (vnode._nextDom) { | ||
| expect.fail('vnode should not have _nextDom:' + vnode._nextDom); | ||
| } | ||
|
|
||
| if (vnode._children) { | ||
| for (let child of vnode._children) { | ||
| if (child) { | ||
| verifyVNodeTree(child); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
JoviDeCroock
approved these changes
Nov 30, 2024
|
This is awesome! Also good spot on nextDom |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a (perhaps futile) desire to reduce the number of files that light up my editor like a Christmas tree, this PR tries to correct a couple hundred or so of our type errors. Switching this line over to just
jsconfig.jsonproduces 1501 TS errors, which this PR brings down to 1292. Only corrects a small fraction of the type errors, and mostly the quick ones at that, but it's a chunk I suppose.The only non-comment/type changes should be in adding an initial param to
createContext()calls & passing{}/nulltoh()/createElement().