Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benches folder #4592

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove benches folder #4592

merged 1 commit into from
Dec 4, 2024

Conversation

JoviDeCroock
Copy link
Member

Looks like our benchmarks submodule already takes care of this

Copy link

github-actions bot commented Dec 4, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-12.26ms - +5.13ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.22ms - +0.16ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +0% (-3.28ms - +0.28ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -3% - +4% (-0.45ms - +0.63ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.73ms - +1.16ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -7% - +0% (-0.15ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -5% - +1% (-1.66ms - +0.27ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +2% (-1.00ms - +0.58ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.02ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +4% (-0.33ms - +0.54ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local937.25ms - 948.38ms-unsure 🔍
-1% - +1%
-12.26ms - +5.13ms
preact-main939.69ms - 953.07msunsure 🔍
-1% - +1%
-5.13ms - +12.26ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local24.84ms - 24.86ms-unsure 🔍
-0% - +0%
-0.00ms - +0.02ms
preact-main24.85ms - 24.85msunsure 🔍
-0% - +0%
-0.02ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.53ms - 16.72ms-unsure 🔍
-1% - +1%
-0.22ms - +0.16ms
preact-main16.49ms - 16.82msunsure 🔍
-1% - +1%
-0.16ms - +0.22ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.65ms - 1.68ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main1.65ms - 1.68msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local73.23ms - 75.78ms-unsure 🔍
-4% - +0%
-3.28ms - +0.28ms
preact-main74.77ms - 77.25msunsure 🔍
-0% - +4%
-0.28ms - +3.28ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local12.85ms - 13.47ms-unsure 🔍
-3% - +4%
-0.33ms - +0.54ms
preact-main12.76ms - 13.36msunsure 🔍
-4% - +2%
-0.54ms - +0.33ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local15.38ms - 16.28ms-unsure 🔍
-3% - +4%
-0.45ms - +0.63ms
preact-main15.43ms - 16.05msunsure 🔍
-4% - +3%
-0.63ms - +0.45ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.49ms - 4.51ms-unsure 🔍
-0% - +0%
-0.02ms - +0.01ms
preact-main4.50ms - 4.51msunsure 🔍
-0% - +0%
-0.01ms - +0.02ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4170
  • Commit: e241fb7

duration

VersionAvg timevs preact-localvs preact-main
preact-local68.53ms - 69.86ms-unsure 🔍
-1% - +2%
-0.73ms - +1.16ms
preact-main68.30ms - 69.65msunsure 🔍
-2% - +1%
-1.16ms - +0.73ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.57ms - 3.60ms-unsure 🔍
-1% - +0%
-0.02ms - +0.02ms
preact-main3.57ms - 3.60msunsure 🔍
-0% - +1%
-0.02ms - +0.02ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.51ms - 31.24ms-faster ✔
0% - 3%
0.02ms - 1.03ms
preact-main31.05ms - 31.75msslower ❌
0% - 3%
0.02ms - 1.03ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local36.69ms - 38.10ms-unsure 🔍
-3% - +2%
-1.08ms - +0.89ms
preact-main36.80ms - 38.17msunsure 🔍
-2% - +3%
-0.89ms - +1.08ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local30.09ms - 31.03ms-unsure 🔍
-3% - +2%
-0.93ms - +0.57ms
preact-main30.16ms - 31.32msunsure 🔍
-2% - +3%
-0.57ms - +0.93ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local23.01ms - 23.60ms-unsure 🔍
-3% - +1%
-0.71ms - +0.32ms
preact-main23.08ms - 23.93msunsure 🔍
-1% - +3%
-0.32ms - +0.71ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.83ms - 22.18ms-unsure 🔍
-3% - +0%
-0.69ms - +0.11ms
preact-main21.94ms - 22.66msunsure 🔍
-0% - +3%
-0.11ms - +0.69ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.80ms - 21.51ms-unsure 🔍
-1% - +3%
-0.31ms - +0.63ms
preact-main20.68ms - 21.30msunsure 🔍
-3% - +1%
-0.63ms - +0.31ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 220
  • Built by: CI #4170
  • Commit: e241fb7

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.04ms - 2.16ms-unsure 🔍
-7% - +0%
-0.15ms - +0.01ms
preact-main2.12ms - 2.23msunsure 🔍
-0% - +7%
-0.01ms - +0.15ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.12ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main1.11ms - 1.11msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.52ms - 35.20ms-unsure 🔍
-5% - +1%
-1.66ms - +0.27ms
preact-main34.65ms - 36.46msunsure 🔍
-1% - +5%
-0.27ms - +1.66ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.22ms - 1.23ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.22ms - 1.22msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local36.85ms - 37.80ms-unsure 🔍
-3% - +2%
-1.00ms - +0.58ms
preact-main36.91ms - 38.16msunsure 🔍
-2% - +3%
-0.58ms - +1.00ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.48ms - 3.52ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main3.48ms - 3.52msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Dec 4, 2024

Size Change: 0 B

Total Size: 62.3 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.13 kB
compat/dist/compat.module.js 4.06 kB
compat/dist/compat.umd.js 4.2 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.71 kB
dist/preact.min.js 4.73 kB
dist/preact.min.module.js 4.73 kB
dist/preact.min.umd.js 4.75 kB
dist/preact.module.js 4.73 kB
dist/preact.umd.js 4.77 kB
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 973 B
jsx-runtime/dist/jsxRuntime.module.js 947 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Dec 4, 2024

Coverage Status

coverage: 99.617%. remained the same
when pulling e241fb7 on remove-benches-folder
into 9087adf on main.

@JoviDeCroock JoviDeCroock merged commit 2d76a3b into main Dec 4, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the remove-benches-folder branch December 4, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants