qe: Default make-qe task to JSON protocol and improve error message
#4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I beleive prisma/team-orm#710 was caused by engine defaulting to GraphQL via `.envrc` file. Error handling in BinaryEngine being broken in this case (prisma/prisma#22636) made finding this out really hard. So, while main fix is done on the client side, I beleive we can adjust few things on the engine side too: - `make-qe` task will now always use JSON protocol. - `make-qe-graphql` task added for cases where it is necessary. For example, using the playground. - Default `PRISMA_ENGINE_PROTOCOL` is removed from `.envrc`. If needed, it can be restored via `.envrc.local`. - Error message adjusted to mention incorrect protocol possiblity. Contributes to prisma/team-orm#710
SevInf
requested review from
laplab and
jkomyno
and removed request for
a team
WASM Size
|
CodSpeed Performance ReportMerging #4644 will not alter performanceComparing Summary
|
🚨 WASM query-engine: 1 benchmark(s) have regressed at least 2%Full benchmark reportAfter changes in b15ddb1 |
Jolg42
approved these changes
Jan 12, 2024
added 2 commits
January 12, 2024 15:16
miguelff
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
I got an expected reproduction, the error message is:
prisma:error Error parsing Graphql query. data did not match any variant of untagged enum GraphqlBody
PrismaClientKnownRequestError: Error parsing Graphql query. data did not match any variant of untagged enum GraphqlBody
at Uo.httpErrorHandler (/Users/miguel/GitHub/prisma/prisma-engines/repro/node_modules/@prisma/client/runtime/binary.js:176:5223)
at /Users/miguel/GitHub/prisma/prisma-engines/repro/node_modules/@prisma/client/runtime/binary.js:176:2481
at Function.onHttpError (/Users/miguel/GitHub/prisma/prisma-engines/repro/node_modules/@prisma/client/runtime/binary.js:165:207)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Uo.request (/Users/miguel/GitHub/prisma/prisma-engines/repro/node_modules/@prisma/client/runtime/binary.js:176:2545)
at async Object.singleLoader (/Users/miguel/GitHub/prisma/prisma-engines/repro/node_modules/@prisma/client/runtime/binary.js:187:5214)
at async wl.request (/Users/miguel/GitHub/prisma/prisma-engines/repro/node_modules/@prisma/client/runtime/binary.js:187:5706)
at async a (/Users/miguel/GitHub/prisma/prisma-engines/repro/node_modules/@prisma/client/runtime/binary.js:192:9691) {
code: undefined,
clientVersion: '5.9.0-dev.10',
meta: undefined
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I beleive prisma/team-orm#710 was caused by engine defaulting to GraphQL
via
.envrcfile. Error handling in BinaryEnginebeing broken in this case (prisma/prisma#22636) made finding this out
really hard.
So, while main fix is done on the client side, I beleive we can adjust
few things on the engine side too:
make-qetask will now always use JSON protocol.make-qe-graphqltask added for cases where it is necessary. Forexample, using the playground.
PRISMA_ENGINE_PROTOCOLis removed from.envrc. If needed,it can be restored via
.envrc.local.For reviewers: I would appreciate if you'd checked out the branch and tested
if instructions here work for you now.
Contributes to prisma/team-orm#710