Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for newline in the source and generator blocks #615

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Add support for newline in the source and generator blocks #615

merged 2 commits into from
Apr 1, 2020

Conversation

Sytten
Copy link
Contributor

@Sytten Sytten commented Mar 26, 2020

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@janpio janpio requested a review from mavilein March 26, 2020 09:06
@janpio janpio modified the milestones: Preview 25, Foo 1 Mar 26, 2020
@mavilein
Copy link
Contributor

Hey @Sytten ,
that looks great overall! The only thing i would like to change is to introduce a separate test case for this. Right now you added this test as an additional thing within the JSON parsing. I could see a different contributor accidentally removing the newline because they don't understand why it is there.
I would suggest to add a test case called e.g. new_lines_in_generators_must_work. There you could simply parse the configuration and explain in a comment that it must not crash. Same applies to comments in datasources.

@Sytten Sytten mentioned this pull request Mar 28, 2020
Closed
@Sytten
Copy link
Contributor Author

Sytten commented Mar 30, 2020

@mavilein can you check my tests

@janpio janpio modified the milestones: Foo 1, Foo 2 Mar 30, 2020
@mavilein mavilein merged commit 571ca7f into prisma:master Apr 1, 2020
@janpio
Copy link
Contributor

janpio commented Apr 1, 2020

Weeeee, congratz @Sytten! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavilein mavilein mavilein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Beta 2
Development

Successfully merging this pull request may close these issues.

Comments being shown as invalid in VSCode
4 participants
@Sytten @CLAassistant @mavilein @janpio