followup PR to address comments for dynamic datasource providers #863
Conversation
mavilein
changed the title
| #[serde(rename_all = "camelCase")] | ||
| #[derive(Clone, Debug, Serialize)] | ||
| pub struct StringFromEnvVar { |
There was a problem hiding this comment.
Taking a closer look at #800 (comment), it's still unclear to me how this construct works. When is from_env_var populated? When is value populated? There seems to be some intent behind how to construct and use this struct, and it's unclear to me what that is.
There was a problem hiding this comment.
Does the line below not clarify that?
There was a problem hiding this comment.
On re-reading it I guess it's fine, though I was hoping it could be clearer. We now have a struct member communicating intent over the whole struct which is something I would expect to live at the top level of the struct declaration site.
But I feel like we've talked quite a bit about this patch already; feel free to merge this PR as-is (:
mavilein
changed the title
mavilein
deleted the
datamodel-parser/followup-feedback-dynamic-providers-pr
branch
followup for this PR to address comments.