Threading Refactor #165
Merged
Threading Refactor #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
2 similar comments
|
/rebase |
|
/rebase |
* feat: mpz-common * reduce visibility of test module * pr feedback
* Adds an ideal ROT functionality to mpz-ot-core * Update ot/mpz-ot-core/src/ideal/ideal_rot.rs Derive Debug for IdealROT Co-authored-by: sinu.eth <[email protected]> * Add feedback * Add more feedback --------- Co-authored-by: sinu.eth <[email protected]>
* add transfer id * update co15 and kos15 * add Output type * feat(mpz-common): ideal functionality utils * refactor ideal functionalities and traits * pr feedback * impl ideal rot * Update crates/mpz-ot/src/ideal/rot.rs Co-authored-by: th4s <[email protected]> --------- Co-authored-by: th4s <[email protected]>
* delete obsolete module * export test-utils and add ideal COT tests
* feat(mpz-common): simple counter * add derives
* refactor(mpz-garble-core): batched garbling * Apply suggestions from code review Co-authored-by: th4s <[email protected]> Co-authored-by: dan <[email protected]> * qualify comment * remove unused msg module * comments --------- Co-authored-by: th4s <[email protected]> Co-authored-by: dan <[email protected]>
* Add generic support for ideal random OT. * Add crate `mpz-ole-core`. * Improved ideal ROT implementation and adapted tests in `mpz-ole-core`. * Remove unnecessary comment. * Add feedback. * Added `Serialize` and `Deserialize` for message types. * Return `Option` instead of `Result`. * Remove unused error enum. * Add transfer id. * Added using `TransferId` in new batch types. * Use `split_off` instead of `drain`. * Return correct number of OLEs from `consume`. * Use `VecDeque` for cache and please clippy. * Use `hybrid-array` and get rid of const generics. * Apply suggestions for improving comments Co-authored-by: dan <[email protected]> * Remove `ByteRepr` from `Field` trait. * Move from `MaskedInput` to `MaskedCorrelation` mental model. * Simplify array creation in `core/sender.rs`. * Add more feedback. - Add default for `BIT_SIZE` - Rename `BitSizeType` -> `BitSize`. * Add comment about which function is evaluated. Co-authored-by: dan <[email protected]> --------- Co-authored-by: dan <[email protected]>
* feat(mpz-common): mt executor * separate context from executor * full mt implementation with queues * remove unused dep * re-enable lints * remove queue, fix bug * bump tlsn-utils * use TestFramedMux * update test
* Add `mpz-ole` content of old branch. * Reworked message enum. * Refactored to work with new `mpz-ole-core`. * Add part of feedback. * Add more feedback. * Add opaque error type. * Add `Display` for `OLEErrorKind` * Use `ok_or_elese` for lazy heap alloc. * Adapted `mpz-ole` to `hybrid-array`. * WIP: Improving API of const generics... * Add random OT for `hybrid-array`. * Adapt `mpz-ole` to use new random OT. * Added feedback. * Use random OT over field elements instead of arrays. * Refactored ideal implementation to use `mpz-common`. * Added more feedback.
* feat(mpz-common): Context::blocking * Apply suggestions from code review Co-authored-by: dan <[email protected]> --------- Co-authored-by: dan <[email protected]>
* WIP: Reimplementing `mpz-share-conversion-core`... - Remove `mpz-share-conversion` IO for now. - Remove unnecessary features in `mpz-share-conversion-core`. * Added A2M conversion methods. * Implemented A2M, added tests and ideal functionalities. * Fix typo. * Improved comments. * Apply suggestions from code review Co-authored-by: sinu.eth <[email protected]> * Add more feedback. * Improve comment. Co-authored-by: dan <[email protected]> * Use deterministic seed for ideal functionalities. --------- Co-authored-by: sinu.eth <[email protected]> Co-authored-by: dan <[email protected]>
* refactor(mpz-garble): fix threading breaking changes * Update crates/mpz-garble/src/protocol/deap/vm.rs Co-authored-by: dan <[email protected]> --------- Co-authored-by: dan <[email protected]>
* refactor(mpz-share-conversion): threading refactor * use default seed
* feat(mpz-common): async sync primitives * update syncer test * add unsync lock method * update async syncer test
* refactor: KOS and preprocessing traits * add bounds to preprocess error * rename pd field
* fix(mpz-common): flush io in syncer * join futures
* fix(mpz-garble): add thread id to otp ids
sinui0
force-pushed
the
threading-refactor
branch
from
a560fff to
836ad67
Compare
sinui0
force-pushed
the
threading-refactor
branch
from
bce2522 to
197d9e8
Compare
sinui0
force-pushed
the
threading-refactor
branch
from
197d9e8 to
e25d123
Compare
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.