Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Changed name of RwTableTag to Target (#422) #431

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Changed name of RwTableTag to Target (#422) #431

merged 1 commit into from
Jun 6, 2023

Conversation

th3093
Copy link
Contributor

@th3093 th3093 commented May 31, 2023

Changed name of RwTableTag to Target in the files stated in the issue#422

These files are:

  • src/zkevm_specs/evm_circuit/table.py
  • src/zkevm_specs/evm_circuit/typing.py
  • src/zkevm_specs/evm_circuit/instruction.py
  • src/zkevm_specs_/copy_circuit.py
  • specs/tables.md
  • tests/evm/test_end_block.py

No other appearance of RwTableTag found. RwTable stayed untouched.

@ChihChengLiang ChihChengLiang self-requested a review June 6, 2023 14:08
ChihChengLiang
ChihChengLiang approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice replacement! It looks good to me. Thanks for the contribution

@ChihChengLiang
Copy link
Collaborator

Merge with one review since this is a simple fix.

@ChihChengLiang ChihChengLiang merged commit 8c21467 into privacy-scaling-explorations:master Jun 6, 2023
@ChihChengLiang ChihChengLiang linked an issue Jun 6, 2023 that may be closed by this pull request
Rename all instances of RwTableTag by Target #422
Closed
@ChihChengLiang ChihChengLiang mentioned this pull request Jun 6, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename all instances of RwTableTag by Target
2 participants
@th3093 @ChihChengLiang