Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break: contributing common structures upstream to SCI #70

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

eddie-knight
Copy link
Contributor

@eddie-knight eddie-knight commented Feb 27, 2025

  • everything I extracted is genericized, simplified, and lives over here now: https://github.com/revanite-io/sci/blob/main/pkg/layer4
  • tests are far from complete
  • we've lost ExecuteInvasiveTest functionality, and I don't yet have a plan for restoring an equivalent. perhaps something to do with checking the user config in the SDK and blocking any tests with change objects present. won't be a small lift to do it that way.
  • Can we move the function name grabber into SCI so that it automatically sets the function path? currently plugin authors need to repeat that line everywhere
  • Can we take this opportunity get rid of the need to return the function name in test sets? (ControlEvaluations)

@eddie-knight
Copy link
Contributor Author

Updating the tests this morning, then will take this out of draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant