Skip to content

Commit

Permalink
Move build jobs to hosted pools (microsoft#22)
Browse files Browse the repository at this point in the history
* Move build jobs to the Hosted VS2017 pool instead of our internal pool
* Move the prepare-release-internalonly job from a team-specific pool to a shared pool with more capacity
* Remove symbol publishing from PR/CI builds since it's not necessary; do it only in release builds
  • Loading branch information
mcooley authored Feb 19, 2019
1 parent cc69faf commit 3e09315
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 27 deletions.
15 changes: 10 additions & 5 deletions build/pipelines/templates/build-app-internal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ jobs:
displayName: Build ${{ parameters.platform }}
condition: ${{ parameters.condition }}
pool:
name: Package ES Custom Demands Lab A
demands:
- msbuild
- visualstudio
- ClientAlias -equals PKGESUTILAPPS
vmImage: vs2017-win2016
variables:
BuildConfiguration: Release
BuildPlatform: ${{ parameters.platform }}
Expand All @@ -39,6 +35,15 @@ jobs:
parameters:
extraMsBuildArgs: '/p:IsStoreBuild=true'

- task: PublishSymbols@2
displayName: Publish symbols
inputs:
symbolsFolder: $(Build.BinariesDirectory)\$(BuildConfiguration)\$(BuildPlatform)
searchPattern: '**/*.pdb'
symbolServerType: teamServices
treatNotIndexedAsWarning: true
symbolsArtifactName: $(System.teamProject)/$(Build.BuildNumber)_$(BuildPlatform)$(BuildConfiguration)

- task: securedevelopmentteam.vss-secure-development-tools.build-task-binskim.BinSkim@3
displayName: Run BinSkim
inputs:
Expand Down
6 changes: 1 addition & 5 deletions build/pipelines/templates/build-app-public.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@ jobs:
displayName: Build ${{ parameters.platform }}
condition: ${{ parameters.condition }}
pool:
name: Package ES Custom Demands Lab A
demands:
- msbuild
- visualstudio
- ClientAlias -equals PKGESUTILAPPS
vmImage: vs2017-win2016
variables:
BuildConfiguration: Release
BuildPlatform: ${{ parameters.platform }}
Expand Down
9 changes: 0 additions & 9 deletions build/pipelines/templates/build-single-architecture.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,3 @@ steps:
artifactName: drop
pathToPublish: $(Build.BinariesDirectory)
parallel: true

- task: PublishSymbols@2
displayName: Publish symbols
inputs:
symbolsFolder: $(Build.BinariesDirectory)\$(BuildConfiguration)\$(BuildPlatform)
searchPattern: '**/*.pdb'
symbolServerType: teamServices
treatNotIndexedAsWarning: true
symbolsArtifactName: $(System.teamProject)/$(Build.BuildNumber)_$(BuildPlatform)$(BuildConfiguration)
6 changes: 1 addition & 5 deletions build/pipelines/templates/package-appxbundle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,7 @@ jobs:
in(dependencies.BuildARM64.result, 'Succeeded', 'SucceededWithIssues', 'Skipped')
)
pool:
name: Package ES Custom Demands Lab A
demands:
- msbuild
- visualstudio
- ClientAlias -equals PKGESUTILAPPS
vmImage: vs2017-win2016
workspace:
clean: outputs
steps:
Expand Down
4 changes: 1 addition & 3 deletions build/pipelines/templates/prepare-release-internalonly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ jobs:
- job: WindowsInternalRelease
dependsOn: Package
pool:
name: Package ES Custom Demands Lab A
demands:
- ClientAlias -equals PKGESUTILAPPS
name: Package ES Lab E
workspace:
clean: outputs
steps:
Expand Down

0 comments on commit 3e09315

Please sign in to comment.