change no-launch-browser to suppress-browser-launch in bit login (tea…

…mbit#1076)
priyankukonar · Jun 17, 2018 · 682740b · 682740b
1 parent 935c9ff
commit 682740b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - fix - operation aborted error when aborting username/pass authentication
 - fix handle tsx files when detectiveOption is empty
 - backward compatibility for components with environments with latest version
+- change no-launch-browser to suppress-browser-launch in bit login flag
 
 ## [13.0.0-dev.11] - 2018-06-13
 

diff --git a/src/api/consumer/lib/login.js b/src/api/consumer/lib/login.js
@@ -3,9 +3,9 @@ import loginToBitSrc from '../../../consumer/login/login';
 
 export default (async function loginAction(
   port: string,
-  noLaunchBrowser?: boolean,
+  suppressBrowserLaunch?: boolean,
   npmrcPath: string,
   skipRegistryConfig: boolean
 ): Promise<{ isAlreadyLoggedIn?: boolean, username?: string }> {
-  return loginToBitSrc(port, noLaunchBrowser, npmrcPath, skipRegistryConfig);
+  return loginToBitSrc(port, suppressBrowserLaunch, npmrcPath, skipRegistryConfig);
 });
diff --git a/src/cli/commands/public-cmds/login-cmd.js b/src/cli/commands/public-cmds/login-cmd.js
@@ -9,7 +9,7 @@ export default class Login extends Command {
   alias = '';
   opts = [
     ['p', 'port <port>', 'port number to open for localhost server (default 8085)'],
-    ['', 'no-launch-browser', 'do not open a browser for authentication'],
+    ['', 'suppress-browser-launch', 'do not open a browser for authentication'],
     ['', 'npmrc-path <path>', 'path to npmrc file to configure bitsrc registry'],
     ['', 'skip-registry-config [boolean]', 'dont configure bitsrc registry']
   ];
@@ -18,12 +18,12 @@ export default class Login extends Command {
     [nothing]: [string[]],
     {
       port,
-      noLaunchBrowser = false,
+      suppressBrowserLaunch = false,
       npmrcPath,
       skipRegistryConfig = false
-    }: { port: string, noLaunchBrowser?: boolean, npmrcPath: string, skipRegistryConfig: boolean }
+    }: { port: string, suppressBrowserLaunch?: boolean, npmrcPath: string, skipRegistryConfig: boolean }
   ): Promise<any> {
-    return login(port, noLaunchBrowser, npmrcPath, skipRegistryConfig).then(
+    return login(port, suppressBrowserLaunch, npmrcPath, skipRegistryConfig).then(
       ({ isAlreadyLoggedIn, username, npmrcPath, writeToNpmrcError }) => ({
         isAlreadyLoggedIn,
         username,

diff --git a/src/consumer/login/login.js b/src/consumer/login/login.js
@@ -26,7 +26,7 @@ const REDIRECT = 302;
 
 export default function loginToBitSrc(
   port: string,
-  noLaunchBrowser?: boolean,
+  suppressBrowserLaunch?: boolean,
   npmrcPath: string,
   skipRegistryConfig: boolean
 ): Promise<{
@@ -101,7 +101,7 @@ export default function loginToBitSrc(
           process.platform
         }`
       );
-      if (!noLaunchBrowser) {
+      if (!suppressBrowserLaunch) {
         console.log(chalk.yellow(`Your browser has been opened to visit:\n${encoded}`)); // eslint-disable-line no-console
         opn(encoded);
       } else {