Update linter version a few other places

Signed-off-by: Bernd Verst <[email protected]>
professorumoh · Nov 11, 2022 · 543780b · 543780b
1 parent 2bad057
commit 543780b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/docker/Dockerfile-dev b/docker/Dockerfile-dev
@@ -1,7 +1,7 @@
 # Based on https://github.com/microsoft/vscode-dev-containers/tree/v0.224.3/containers/go/.devcontainer/base.Dockerfile
 
-# [Choice] Go version: 1, 1.18, etc
-ARG GOVERSION=1.18
+# [Choice] Go version: 1, 1.19, etc
+ARG GOVERSION=1.19
 FROM golang:${GOVERSION}-bullseye
 
 # [Option] Install zsh
@@ -15,7 +15,7 @@ ARG DAPR_CLI_VERSION="latest"
 ARG PROTOC_VERSION="21.1"
 ARG PROTOC_GEN_GO_VERSION="1.28"
 ARG PROTOC_GEN_GO_GRPC_VERSION="1.2"
-ARG GOLANGCI_LINT_VERSION="1.45.2"
+ARG GOLANGCI_LINT_VERSION="1.50.1"
 
 # This Dockerfile adds a non-root 'dapr' user with sudo access. However, for Linux,
 # this user's GID/UID must match your local user UID/GID to avoid permission issues

diff --git a/docker/README.md b/docker/README.md
@@ -12,7 +12,7 @@ This includes dockerfiles to build Dapr release and debug images and development
 
 The Dev Container can be rebuilt with custom options. Relevant args (and their default values) include:
 
-* `GOVERSION` (default: `1.18`)
+* `GOVERSION` (default: `1.19`)
 * `INSTALL_ZSH` (default: `true`)
 * `KUBECTL_VERSION` (default: `latest`)
 * `HELM_VERSION` (default: `latest`)

diff --git a/docs/development/developing-dapr.md b/docs/development/developing-dapr.md
@@ -63,7 +63,7 @@ This command will:
 - format, test and lint all the code 
 - check if you forgot to `git commit` something
 
-Note: To run linter locally, please use golangci-lint version v1.45.2, otherwise you might encounter errors. You can download version v1.45.2 [here](https://github.com/golangci/golangci-lint/releases/tag/v1.45.2).
+Note: To run linter locally, please use golangci-lint version v1.50.1, otherwise you might encounter errors. You can download version v1.50.1 [here](https://github.com/golangci/golangci-lint/releases/tag/v1.50.1).
 
 ## Debug Dapr
 

diff --git a/docs/development/setup-dapr-development-env.md b/docs/development/setup-dapr-development-env.md
@@ -23,11 +23,11 @@ This document helps you get started developing Dapr. If you find any problems wh
 
 ## Go (Golang)
 
-1. Download and install [Go 1.18 or later](https://golang.org/doc/install#tarball).
+1. Download and install [Go 1.19 or later](https://golang.org/doc/install#tarball).
 
 2. Install [Delve](https://github.com/go-delve/delve/tree/master/Documentation/installation) for Go debugging, if desired.
 
-3. Install [golangci-lint](https://golangci-lint.run/usage/install) version 1.45.2.
+3. Install [golangci-lint](https://golangci-lint.run/usage/install) version 1.50.1.
 
 ## Setup a Kubernetes development environment