Skip to content

Commit

Permalink
[GFS2/DLM] fix GFS2 circular dependency
Browse files Browse the repository at this point in the history
On Sun, Jan 28, 2007 at 11:08:18AM +0100, Jiri Slaby wrote:
> Andrew Morton napsal(a):
> >Temporarily at
> >
> >	http://userweb.kernel.org/~akpm/2.6.20-rc6-mm1/
>
> Unable to select IPV6. Menuconfig doesn't offer it when INET is selected.
> When it's not it appears in the menu, but after state change it gets away.
> The same behaviour in xconfig, gconfig.
>
> $ mkdir ../a/tst
> $ make O=../a/tst menuconfig
>   HOSTCC  scripts/basic/fixdep
> [...]
>   HOSTLD  scripts/kconfig/mconf
> scripts/kconfig/mconf arch/i386/Kconfig
> Warning! Found recursive dependency: INET GFS2_FS_LOCKING_DLM SYSFS
> OCFS2_FS INET
>
> Maybe this is the problem?

Yes, patch below.

> regards,

cu
Adrian

<--  snip  -->

This patch fixes a circular dependency by letting GFS2_FS_LOCKING_DLM
and DLM depend on instead of select SYSFS.

Since SYSFS depends on EMBEDDED this change shouldn't cause any problems
for users.

Signed-off-by: Adrian Bunk <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Signed-off-by: Steven Whitehouse <[email protected]>
  • Loading branch information
AdrianBunk authored and swhiteho committed Feb 5, 2007
1 parent 67f5589 commit 0011727
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions fs/dlm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ menu "Distributed Lock Manager"

config DLM
tristate "Distributed Lock Manager (DLM)"
depends on IPV6 || IPV6=n
depends on SYSFS && (IPV6 || IPV6=n)
select CONFIGFS_FS
select SYSFS
select IP_SCTP if DLM_SCTP
help
A general purpose distributed lock manager for kernel or userspace
Expand Down
3 changes: 1 addition & 2 deletions fs/gfs2/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,10 @@ config GFS2_FS_LOCKING_NOLOCK

config GFS2_FS_LOCKING_DLM
tristate "GFS2 DLM locking module"
depends on GFS2_FS && NET && INET && (IPV6 || IPV6=n)
depends on GFS2_FS && SYSFS && NET && INET && (IPV6 || IPV6=n)
select IP_SCTP if DLM_SCTP
select CONFIGFS_FS
select DLM
select SYSFS
help
Multiple node locking module for GFS2

Expand Down

0 comments on commit 0011727

Please sign in to comment.