IB/rds: suppress incompatible protocol when version is known

Add an else to only print the incompatible protocol message when version hasn't been established. Signed-off-by: Mike Marciniszyn <[email protected]> Signed-off-by: David S. Miller <[email protected]>
progmanos · Dec 26, 2012 · a496759 · a496759
1 parent f2e9bd7
commit a496759
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
@@ -434,12 +434,11 @@ static u32 rds_ib_protocol_compatible(struct rdma_cm_event *event)
 		version = RDS_PROTOCOL_3_0;
 		while ((common >>= 1) != 0)
 			version++;
-	}
-	printk_ratelimited(KERN_NOTICE "RDS: Connection from %pI4 using "
-			"incompatible protocol version %u.%u\n",
-			&dp->dp_saddr,
-			dp->dp_protocol_major,
-			dp->dp_protocol_minor);
+	} else
+		printk_ratelimited(KERN_NOTICE "RDS: Connection from %pI4 using incompatible protocol version %u.%u\n",
+				&dp->dp_saddr,
+				dp->dp_protocol_major,
+				dp->dp_protocol_minor);
 	return version;
 }