Skip to content

Commit

Permalink
mac80211: use del_timer_sync for final sta cleanup timer deletion
Browse files Browse the repository at this point in the history
This is a very old bug, but there's nothing that prevents the
timer from running while the module is being removed when we
only do del_timer() instead of del_timer_sync().

The timer should normally not be running at this point, but
it's not clearly impossible (or we could just remove this.)

Cc: [email protected]
Tested-by: Ben Greear <[email protected]>
Signed-off-by: Johannes Berg <[email protected]>
  • Loading branch information
jmberg-intel committed Jan 3, 2013
1 parent 97f97b1 commit a56f992
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/mac80211/sta_info.c
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,7 @@ void sta_info_init(struct ieee80211_local *local)

void sta_info_stop(struct ieee80211_local *local)
{
del_timer(&local->sta_cleanup);
del_timer_sync(&local->sta_cleanup);
sta_info_flush(local, NULL);
}

Expand Down

0 comments on commit a56f992

Please sign in to comment.