Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
slob: Check for NULL pointer before calling ctor()
While doing some code inspection, I noticed that the slob constructor method can be called with a NULL pointer. If memory is tight and slob fails to allocate with slob_alloc() or slob_new_pages() it still calls the ctor() method with a NULL pointer. Looking at the first ctor() method I found, I noticed that it can not handle a NULL pointer (I'm sure others probably can't either): static void sighand_ctor(void *data) { struct sighand_struct *sighand = data; spin_lock_init(&sighand->siglock); init_waitqueue_head(&sighand->signalfd_wqh); } The solution is to only call the ctor() method if allocation succeeded. Acked-by: Christoph Lameter <[email protected]> Signed-off-by: Steven Rostedt <[email protected]> Signed-off-by: Pekka Enberg <[email protected]>
- Loading branch information