Fix ViewManager.receiveCommand nullability (facebook#44531)

Summary: Pull Request resolved: facebook#44531 Changelog: [Internal] Properly propagate the `Nullable` to the delegates. Reviewed By: rshest Differential Revision: D57218665 fbshipit-source-id: 2783ad9b37688e0928ad2e3cf6a2ab1f41190fe7
program247365 · May 14, 2024 · 6876775 · 6876775
1 parent 1a56b9a
commit 6876775
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/packages/react-native-codegen/src/generators/components/GeneratePropsJavaDelegate.js b/packages/react-native-codegen/src/generators/components/GeneratePropsJavaDelegate.js
@@ -74,7 +74,7 @@ const PropSetterTemplate = ({propCases}: {propCases: string}) =>
 const CommandsTemplate = ({commandCases}: {commandCases: string}) =>
   `
   @Override
-  public void receiveCommand(T view, String commandName, ReadableArray args) {
+  public void receiveCommand(T view, String commandName, @Nullable ReadableArray args) {
     switch (commandName) {
       ${commandCases}
     }

diff --git a/.../src/generators/components/__tests__/__snapshots__/GeneratePropsJavaDelegate-test.js.snap b/.../src/generators/components/__tests__/__snapshots__/GeneratePropsJavaDelegate-test.js.snap
@@ -213,7 +213,7 @@ public class CommandNativeComponentManagerDelegate<T extends View, U extends Bas
   }
 
   @Override
-  public void receiveCommand(T view, String commandName, ReadableArray args) {
+  public void receiveCommand(T view, String commandName, @Nullable ReadableArray args) {
     switch (commandName) {
       case \\"flashScrollIndicators\\":
         mViewManager.flashScrollIndicators(view);
@@ -263,7 +263,7 @@ public class CommandNativeComponentManagerDelegate<T extends View, U extends Bas
   }
 
   @Override
-  public void receiveCommand(T view, String commandName, ReadableArray args) {
+  public void receiveCommand(T view, String commandName, @Nullable ReadableArray args) {
     switch (commandName) {
       case \\"handleRootTag\\":
         mViewManager.handleRootTag(view, args.getDouble(0));

diff --git a/...tive/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.java b/...tive/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.java
@@ -137,5 +137,5 @@ public void setProperty(T view, String propName, @Nullable Object value) {
   }
 
   @Override
-  public void receiveCommand(T view, String commandName, ReadableArray args) {}
+  public void receiveCommand(T view, String commandName, @Nullable ReadableArray args) {}
 }
diff --git a/...t-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerDelegate.java b/...t-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerDelegate.java
@@ -21,5 +21,5 @@
 public interface ViewManagerDelegate<T extends View> {
   void setProperty(T view, String propName, @Nullable Object value);
 
-  void receiveCommand(T view, String commandName, ReadableArray args);
+  void receiveCommand(T view, String commandName, @Nullable ReadableArray args);
 }