Skip to content

Commit

Permalink
extract param type (facebook#44498)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#44498

Changelog: [internal]

Quick refactor to reduce commit noise in the following diff in the stack

Reviewed By: blakef

Differential Revision: D57140480

fbshipit-source-id: aa1fef83d5347b8a11651d3d5c4112b4adf7a7d5
  • Loading branch information
EdmondChuiHW authored and facebook-github-bot committed May 9, 2024
1 parent 7835aa4 commit 75dc42f
Showing 1 changed file with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ type RequestMetadata = $ReadOnly<{
frontendUserAgent: string | null,
}>;

type ResponseMetadata = $ReadOnly<{
pageId: string | null,
frontendUserAgent: string | null,
}>;

class DeviceEventReporter {
#eventReporter: EventReporter;

Expand Down Expand Up @@ -72,10 +77,7 @@ class DeviceEventReporter {
logResponse(
res: CDPResponse<>,
origin: 'device' | 'proxy',
metadata: $ReadOnly<{
pageId: string | null,
frontendUserAgent: string | null,
}>,
metadata: ResponseMetadata,
): void {
const pendingCommand = this.#pendingCommands.get(res.id);
if (!pendingCommand) {
Expand Down

0 comments on commit 75dc42f

Please sign in to comment.