Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass store port correctly to spawned actors #186

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

rwschonberg
Copy link
Contributor

No description provided.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10626581095

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.7%) to 69.826%

Totals Coverage Status
Change from base Build 10472006984: 3.7%
Covered Lines: 1201
Relevant Lines: 1720

💛 - Coveralls

Copy link
Contributor

@jmxpearson jmxpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tests all pass on my machine, along with minimal demos (both).

Copy link
Collaborator

@draelos draelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. Tests pass and all minimal demos work, including if I change the redis port number and make both actors spawn. I did note that logging doesn't work for spawned actors, but I think that will be fixed in later zmq-associated pulls.

@draelos draelos merged commit bcdb61f into project-improv:dev Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants