Convert lb tags to br tags in HTML output (#1484)

app/helpers/arclight/ead_format_helpers.rb

@@ -27,6 +27,7 @@ def ead_to_html_scrubber
       Loofah::Scrubber.new do |node|
         format_render_attributes(node) if node.attr('render').present?
         convert_to_span(node) if CONVERT_TO_SPAN_TAGS.include? node.name
+        convert_to_br(node) if CONVERT_TO_BR_TAG.include? node.name
         format_links(node) if %w[extptr extref extrefloc ptr ref].include? node.name
         format_lists(node) if %w[list chronlist].include? node.name
         node
@@ -35,11 +36,17 @@ def ead_to_html_scrubber
 
     # Tags that should be converted to <span> tags because of formatting conflicts between XML and HTML
     CONVERT_TO_SPAN_TAGS = ['title'].freeze
+    # Tags that should be converted to <span> tags because of formatting conflicts between XML and HTML
+    CONVERT_TO_BR_TAG = ['lb'].freeze
 
     def convert_to_span(node)
       node.name = 'span'
     end
 
+    def convert_to_br(node)
+      node.name = 'br'
+    end
+
     def condense_whitespace(str)
       str.squish.strip.gsub(/>[\n\s]+</, '><')
     end

spec/helpers/arclight/ead_format_helpers_spec.rb

@@ -39,6 +39,11 @@
         content = helper.render_html_tags(value: %w[<title>Title</title>])
         expect(content).to eq_ignoring_whitespace '<span>Title</span>'
       end
+
+      it 'converts <lb> tags to <br> tags' do
+        content = helper.render_html_tags(value: %w[My<lb/>line-break])
+        expect(content).to eq_ignoring_whitespace 'My<br>line-break'
+      end
     end
 
     describe 'nodes with @render attributes' do