Bancorv3 adapter #26
Open
Bancorv3 adapter #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, sell function, and buy function
…iceAt, and optimizations
…tions and minor fixes
PierreMkt
reviewed
Jul 16, 2024
| /// @notice Calculates pair prices for specified amounts | ||
| /// @param _amountIn The amount of the token being sold | ||
| /// @param _sellToken the token to sell | ||
| /// @param _buyToken The token ro buy |
There was a problem hiding this comment.
Suggested change
| /// @param _buyToken The token ro buy | |
| /// @param _buyToken The token to buy |
PierreMkt
reviewed
Jul 16, 2024
| /// @param _buyToken The token ro buy | ||
| /// @return (fraction) price as a fraction corresponding to the provided | ||
| /// amount | ||
| function getPriceAt( |
There was a problem hiding this comment.
would appreciate more comments of what's going on with the price caches. This is really hard to understand as is
PierreMkt
reviewed
Jul 16, 2024
|
|
||
| /// @notice Get the liquidity of _buyToken and _sellToken in a specific pool | ||
| /// @param _sellToken the token to sell | ||
| /// @param _buyToken The token ro buy |
There was a problem hiding this comment.
Suggested change
| /// @param _buyToken The token ro buy | |
| /// @param _buyToken The token to buy |
mp-web3
added a commit
that referenced
this pull request
Oct 14, 2024
…adapter-fixes Feature/sc 1989/sfraxeth adapter fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.