Prevent accessing explode results when empty

Related to Generate screenshots for links Kovah#18
prplecake · Apr 17, 2021 · 499a876 · 499a876
1 parent 98567b8
commit 499a876
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/app/Helper/HtmlMeta.php b/app/Helper/HtmlMeta.php
@@ -67,13 +67,14 @@ protected static function buildLinkMeta(array $metaTags, string $url): array
             ?? null;
 
         //Edge case of Youtube only (because of Youtube EU cookie consent)
-        if (str_contains($url, 'youtube')) {
-            if (is_null($thumbnail)) {
-                //Formula based on https://stackoverflow.com/a/2068371
-                $explode = explode('v=', $url);
-                //https://img.youtube.com/vi/[video-id]/mqdefault.jpg
-                $thumbnail = 'https://img.youtube.com/vi/'.$explode[1].'/mqdefault.jpg';
-            }
+        if (str_contains($url, 'youtube')
+            && str_contains($url, 'v=')
+            && is_null($thumbnail)
+        ) {
+            //Formula based on https://stackoverflow.com/a/2068371
+            $explode = explode('v=', $url);
+            //https://img.youtube.com/vi/[video-id]/mqdefault.jpg
+            $thumbnail = 'https://img.youtube.com/vi/' . $explode[1] . '/mqdefault.jpg';
         }
 
         return [