Skip to content

Commit

Permalink
Fix Helm chart incorrectly handling Kubernetes versions containing a …
Browse files Browse the repository at this point in the history
…"+" character, causing deployment errors for PodDisruptionBudget in certain environments (signalfx#1144)
  • Loading branch information
jvoravong authored Feb 6, 2024
1 parent 6917ba9 commit ed66932
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
12 changes: 12 additions & 0 deletions .chloggen/fix-pdb-k8s-version-bug.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: chart
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Fix Helm chart incorrectly handling Kubernetes versions containing a "+" character, causing deployment errors for PodDisruptionBudget in certain environments
# One or more tracking issues related to the change
issues: [1144]
# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
2 changes: 1 addition & 1 deletion helm-charts/splunk-otel-collector/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ compatibility with the old config group name: "otelAgent".
The apiVersion for podDisruptionBudget policies.
*/}}
{{- define "splunk-otel-collector.PDB-apiVersion" -}}
{{- if (semverCompare ">= 1.21.0" .Capabilities.KubeVersion.Version) -}}
{{- if .Capabilities.APIVersions.Has "policy/v1" -}}
{{- print "policy/v1" -}}
{{- else -}}
{{- print "policy/v1beta1" -}}
Expand Down

0 comments on commit ed66932

Please sign in to comment.