Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements, issue fixes #21

Closed
wants to merge 17 commits into from
Closed

Improvements, issue fixes #21

wants to merge 17 commits into from

Conversation

subnut
Copy link
Contributor

@subnut subnut commented Oct 17, 2020 •
edited
Loading

Continued at #23

@subnut subnut changed the title Workaround for folds misbehaving on scrolldown Workaround for folds misbehaving on scrolldown and misc. other improvements Oct 31, 2020
@subnut subnut force-pushed the master branch 2 times, most recently from b2fe2b8 to b814d2f Compare October 31, 2020 10:57
@subnut subnut mentioned this pull request Oct 31, 2020
Closed
@subnut subnut force-pushed the master branch 5 times, most recently from b095bd9 to 788dc2b Compare November 1, 2020 04:54
@subnut subnut force-pushed the master branch 4 times, most recently from 4ba9665 to d77d5f1 Compare November 16, 2020 11:19
@subnut
Code commented and linted
321bf9d
@subnut
Add variable to disable vim-smoothie completely
fa61acd 
Implements the _Minimal Solution_ as discussed in psliwka#19 (comment)
Can be used as-is, or can be implemented using a dedicated command if
required in the future.

Closes psliwka#17
Closes psliwka#19
@subnut
Copy link
Contributor Author

subnut commented Nov 16, 2020

@psliwka May I request you to make me a collaborator of this repo?

PS. yep, It was me who mailed you

@subnut subnut force-pushed the master branch 8 times, most recently from d436aff to c097b45 Compare November 17, 2020 03:52
@subnut
Copy link
Contributor Author

subnut commented Nov 17, 2020 •
edited
Loading

My GeoGebra plot comparing the old algorithm with two newer ones, out of which one has been implemented

color algo
brown old algo
red new algo, implemented
green contestant algo, not implemented

variable a represents g:smoothie_base_speed

axis meaning
x no. of remaining lines
y speed

@subnut
Do not include G and gg in default mappings
afd0356 
They are not scroll commands. I think it's better to leave them out of
default mappings, as the user may face unintended behaviour. The <Plug>
mappings can be used to create custom mappings if the user desires.
@subnut subnut mentioned this pull request Nov 18, 2020
Closed
@benwoodward
Copy link

Scrolling is noticeably smoother, nice!

@subnut
Fixed the patch number required
fa169dc 
<Cmd> mappings were introduced in vim in patch 8.2.1978, not 8.2.1280
This was referenced Nov 18, 2020
Closed
Closed
Open
Closed
@subnut
Improve 'Customization' section of README.md
a80e8fb 
Include new customization options.
Closes psliwka#22
@subnut subnut changed the title Workaround for folds misbehaving on scrolldown and misc. other improvements Improvements, issue fixes Nov 18, 2020
@subnut
Copy link
Contributor Author

subnut commented Nov 18, 2020 •
edited
Loading

Two requests to @psliwka

  • Don't squash and merge, do a simple merge
  • Make me a collaborator
  • Move this repo to the @vim-smoothie organization

@subnut
Some improvements
1cefa9c 
- Previously bell rang as-soon-as we reached buffer-end. Now it imitates
  natural vim behaviour better.
- Now g:smoothie_bell_enabled sets it's default from the value of
  &belloff
- Removed code comments for smoothie#G() because it's exactly the same
  as smoothie#gg()
- Fixed minor problem in ^F
@subnut
Update LICENSE
3655f2c
@subnut
Copy link
Contributor Author

subnut commented Nov 20, 2020 •
edited
Loading

@psliwka I suggest we move this repo to the @vim-smoothie organization I have created for specifically this plugin.
I have sent an invitation to you to become an owner of the organization.

If you agree to my suggestion, then please have a look at the following article on how to transfer ownership -

https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/transferring-a-repository

I ask for transfer of ownership because it is better to have an organization for a plugin (similar to vim-airline) and because transfer of ownership ensures smooth (pun intended) transition for the users, PRs, issues, etc.
For e.g.
https://github.com/bling/vim-airline automatically redirects to https://github.com/vim-airline/vim-airline
https://github.com/w0rp/ale redirects to https://github.com/dense-analysis/ale
etc.


Hope you agree

@psliwka
Copy link
Owner

psliwka commented Nov 21, 2020 •
edited
Loading

Wow, this is an impressive amount of work, thanks! I'm starting to review this now. Given the volume of changes, please bear with me till I get to the end ;) I'll post any potential questions as I go.

psliwka
psliwka reviewed Nov 21, 2020
View reviewed changes
autoload/smoothie.vim Outdated Show resolved Hide resolved
@subnut

This comment has been minimized.

Sign in to view
@subnut
Copy link
Contributor Author

subnut commented Nov 21, 2020

@psliwka I suggest we move this repo to the @vim-smoothie organization I have created for specifically this plugin.

Are we going to?

I have sent an invitation to you to become an owner of the organization.

Did you receive it?

@psliwka
Copy link
Owner

psliwka commented Nov 21, 2020

@psliwka After you finish your review, I shall push a commit of all the changes you suggest tomorrow. It's past midnight here 🥱

No worries, take your time :)

P.S. What's the time at your place right now? It's 00:10 here at my place...

I currently live in GMT+1, so 19:44 right now ;)

@subnut
Copy link
Contributor Author

subnut commented Nov 22, 2020

I have made the requested changes in a different branch, so had to open a new PR
@psliwka Please check if your requests have been implemented in vim-smoothie#23

@subnut subnut closed this Nov 22, 2020
@psliwka psliwka mentioned this pull request Nov 22, 2020
Closed
psliwka added a commit that referenced this pull request Jan 17, 2021
@psliwka
Tweak the cursor velocity curve
4bb75e5 
Improve user experience by making the speed profile perceivably
smoother. Based on @subnut's experiments from
#21 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psliwka psliwka psliwka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subnut @benwoodward @psliwka