validate_failures.py: Fix performance regression

2013-02-06 Bernhard Reutner-Fischer <[email protected]> * testsuite-management/validate_failures.py (IsInterestingResult): Fix performance regression From-SVN: r195811
pspdev · Feb 6, 2013 · 143c83f · 143c83f
1 parent 4762585
commit 143c83f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/contrib/ChangeLog b/contrib/ChangeLog
@@ -1,3 +1,8 @@
+2013-02-06  Bernhard Reutner-Fischer  <[email protected]>
+
+	* testsuite-management/validate_failures.py
+	(IsInterestingResult): Fix performance regression
+
 2013-02-04  Richard Sandiford  <[email protected]>
 
 	* update-copyright.py: New file.

diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py
@@ -62,6 +62,7 @@
 
 # Handled test results.
 _VALID_TEST_RESULTS = [ 'FAIL', 'UNRESOLVED', 'XPASS', 'ERROR' ]
+_VALID_TEST_RESULTS_REX = re.compile("%s" % "|".join(_VALID_TEST_RESULTS))
 
 # Subdirectory of srcdir in which to find the manifest file.
 _MANIFEST_SUBDIR = 'contrib/testsuite-management'
@@ -210,7 +211,7 @@ def IsInterestingResult(line):
   if '|' in line:
     (_, line) = line.split('|', 1)
     line = line.strip()
-  return any(line.startswith(result) for result in _VALID_TEST_RESULTS)
+  return bool(_VALID_TEST_RESULTS_REX.match(line))
 
 
 def IsInclude(line):