Skip to content

Commit

Permalink
Swapped run_all for reload.
Browse files Browse the repository at this point in the history
This means hitting return will not reload rails server,
instead 'r' or 'reload' must be issued.
  • Loading branch information
Tim Preston committed Oct 17, 2011
1 parent 39e1e40 commit 3ac6507
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 13 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
.bundle
Gemfile.lock
pkg/*
.rvmrc
8 changes: 3 additions & 5 deletions lib/guard/rails.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ def initialize(watchers = [], options = {})
def start
server = options[:server] ? "#{options[:server]} and " : ""
UI.info "Guard::Rails will now restart your app on port #{options[:port]} using #{server}#{options[:environment]} environment."
run_all if options[:start_on_start]
reload if options[:start_on_start]
end

def run_all
def reload
UI.info "Restarting Rails..."
Notifier.notify("Rails restarting on port #{options[:port]} in #{options[:environment]} environment...", :title => "Restarting Rails...", :image => :pending)
if runner.restart
Expand All @@ -41,15 +41,13 @@ def run_all
end
end

alias :reload :run_all

def stop
Notifier.notify("Until next time...", :title => "Rails shutting down.", :image => :pending)
runner.stop
end

def run_on_change(paths)
run_all
reload
end
end
end
Expand Down
16 changes: 8 additions & 8 deletions spec/lib/guard/rails_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

context 'start on start' do
it "should show the right message and run startup" do
guard.expects(:run_all).once
guard.expects(:reload).once
ui_expectation
guard.start
end
Expand All @@ -29,14 +29,14 @@
let(:options) { { :start_on_start => false } }

it "should show the right message and not run startup" do
guard.expects(:run_all).never
guard.expects(:reload).never
ui_expectation
guard.start
end
end
end

describe '#run_all' do
describe '#reload' do
let(:pid) { '12345' }

before do
Expand All @@ -56,7 +56,7 @@
Guard::UI.expects(:info).with(regexp_matches(/#{pid}/))
Guard::Notifier.expects(:notify).with(regexp_matches(/Rails restarted/), has_entry(:image => :success))

guard.run_all
guard.reload
end
end

Expand All @@ -70,11 +70,11 @@
Guard::UI.expects(:info).with(regexp_matches(/Rails NOT restarted/))
Guard::Notifier.expects(:notify).with(regexp_matches(/Rails NOT restarted/), has_entry(:image => :failed))

guard.run_all
guard.reload
end
end
end

describe '#stop' do
it "should stop correctly" do
Guard::Notifier.expects(:notify).with('Until next time...', anything)
Expand All @@ -83,8 +83,8 @@
end

describe '#run_on_change' do
it "should run on change" do
guard.expects(:run_all).once
it "should reload on change" do
guard.expects(:reload).once
guard.run_on_change([])
end
end
Expand Down

0 comments on commit 3ac6507

Please sign in to comment.