Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update recvuntil
What's this Pull Request for?
Choose one or more of the following items.
Please explain the detail here:
Bug fix: Do not sleep when received the delim.
Feat: Added sleep_time argument.
What have you done so far?
Tell me what you've tested to assure your change is right.
python -m unittest
)(It's not mandatory to check even one of them, but test cases make it easy for the author to review your PR.)
Comment
recvuntil
が成功したかどうかに関わらずsleep(0.01)
を挟むのはパフォーマンス上の問題があるので、成功した際にはsleep
を行なわないようにしました。また、sleep
の長さを引数で設定できる様にしました。疑問点としてそもそも
delim
が返ってくるまでrecv(size, timeout=-1)
を回しているのでここでブロッキングが起こるはずで、追加でsleep
を入れる理由が分かりませんでした。