Fix SNI Handling in Socket class when sni is unspecified #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LTGM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SNI Handling in Socket class when sni is unspecified
What's this Pull Request for?
Choose one or more of the following items.
Please explain the detail here:
Fixes an issue where SNI was not enabled when
ssl=Truewas specified in the Socket without explicitly specifying SNI.In testing, uses the site (https://check-tls.akamaized.net/v1/tlssni.json), which returns the SNI status of the request.
What have you done so far?
Tell me what you've tested to assure your change is right.
python -m unittest)(It's not mandatory to check even one of them, but test cases make it easy for the author to review your PR.)
Comment