Support requiring user to pass SMS verification to post #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PichuChen
changed the title
|
This should simply be implemented as "require SMS verification to post". |
wens
reviewed
Apr 23, 2022
wens
reviewed
Apr 23, 2022
wens
reviewed
Apr 23, 2022
wens
changed the title
PichuChen
force-pushed
the
pichu.taiwan_phone
branch
from
869f7b0 to
fb63a83
Compare
IepIweidieng
reviewed
May 2, 2022
hungte
requested changes
Jun 8, 2023
PichuChen
force-pushed
the
pichu.taiwan_phone
branch
from
3b20930 to
a97886c
Compare
|
Rebase, not merge in master branch. |
PichuChen
force-pushed
the
pichu.taiwan_phone
branch
2 times, most recently
from
fb63a83 to
ab5a1a3
Compare
PichuChen
changed the title
Signed-off-by: Pichu Chen <[email protected]>
PichuChen
force-pushed
the
pichu.taiwan_phone
branch
from
ab5a1a3 to
473e004
Compare
PichuChen
changed the title
IepIweidieng
suggested changes
Jun 8, 2023
| /* | ||
| * Check if user phone number is verified by sms | ||
| * | ||
| * This function check if current user has already register their |
There was a problem hiding this comment.
check (1st-person or plural or infinitive v.) → checks (3rd-person singular v.)
| * | ||
| * Please note that, ptt system might have two different users with the same userid, | ||
| * but this won't happen at the same time. Therefore. we need to use firstlogin as the second | ||
| * parameter. And, ptt only accept phone registrations from Taiwan since July 2021 |
There was a problem hiding this comment.
And (conj.) → Also (adv.)
There was a problem hiding this comment.
Also, accept (1st-person or plural or infinitive v.) → accepts (3rd-person singular v.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement:
Changes:
is_taiwan_phone()which determine if current user is registered phone number.const char * postperm_msg(const char *bname).BRD_NEEDS_SMS_VERIFICATION (0x20000000)for this function.Screenshots:
TBD, Still try to build without verifydb lib
Remark:
USE_SMS_VERIFICATIONand flagUSE_VERIFYDBwhen use this function.TODO: