Skip to content

Commit

Permalink
Cleaning up code
Browse files Browse the repository at this point in the history
  • Loading branch information
mussajoop committed Aug 27, 2022
1 parent 407429b commit 080ccce
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 9 deletions.
13 changes: 7 additions & 6 deletions app/controllers/languages_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,12 @@ def remove_from_volunteer
end

private
def set_language
@language = Language.find(params[:id] || params[:language_id])
end

def language_params
params.require(:language).permit(:name)
end
def set_language
@language = Language.find(params[:id] || params[:language_id])
end

def language_params
params.require(:language).permit(:name)
end
end
2 changes: 1 addition & 1 deletion app/views/languages/edit.html.erb
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<%= render partial: "form", locals: { title: "Edit Language", language: @language } %>
<%= render partial: "form", locals: { title: "Edit Language", language: @language } %>
3 changes: 2 additions & 1 deletion app/views/users/_languages.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
<tr>
<td><%= lang.name %></td>
<td>
<%= link_to "Delete", language_remove_from_volunteer_path(lang), class: "btn btn-danger", method: :delete %>
<%= link_to "Delete", language_remove_from_volunteer_path(lang), class: "btn btn-danger",
method: :delete %>
</td>
</tr>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion db/seeds/db_populator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,6 @@ def create_languages(casa_org)
end

def create_language(name, casa_org)
Language.find_or_create_by!(name:, casa_org:)
Language.find_or_create_by!(name: name, casa_org: casa_org)
end
end

0 comments on commit 080ccce

Please sign in to comment.