Remove -open(Utils) compile flag hack

Summary:public
Eliminate the use of the -open Utils command line option passed to the compiler in favor of `open! Utils` in each source file.  While slightly convenient, this option causes more headaches than it is worth with other tools e.g. merlin.

Reviewed By: jvillard

Differential Revision: D3168193

fb-gh-sync-id: 4285ef6
fbshipit-source-id: 4285ef6

CONTRIBUTING.md

@@ -18,7 +18,3 @@ us a line at [email protected]. Thanks!
   `infer/tests/codetoanalyze/` and
   `infer/tests/{endtoend,frontend}/`. To run the all tests, execute
   `make test`.
-
-## Hacking
-
-* Be aware that the build system implicitly opens the Utils module.

infer/.merlin

@@ -10,6 +10,5 @@ PKG str
 PKG unix
 PKG yojson
 PKG zip
-FLG -open Utils
 FLG -principal -safe-string -short-paths -strict-formats -strict-sequence
 FLG -w +a-4-9-40-41-42-45-48-50

infer/src/IR/attributesTable.ml

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 module F = Format
 module L = Logging
 

infer/src/IR/attributesTable.mli

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module to manage the table of attributes. *)
 
 

infer/src/IR/cfg.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 module L = Logging
 module F = Format
 

infer/src/IR/cfg.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (**  Control Flow Graph for Interprocedural Analysis *)
 
 (** {2 ADT node and proc_desc} *)

infer/src/IR/cg.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for call graphs *)
 
 module L = Logging

infer/src/IR/cg.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for call graphs *)
 
 type in_out_calls =

infer/src/IR/csu.ml

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Internal representation of data structure for Java, Objective-C and C++ classes,
     C-style structs struct and union,
     And Objective C protocol *)

infer/src/IR/csu.mli

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Internal representation of data structure for Java, Objective-C and C++ classes,
     C-style structs struct and union,
     And Objective C protocol *)

infer/src/IR/ident.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for Names and Identifiers *)
 
 module L = Logging

infer/src/IR/ident.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Identifiers: program variables and logical variables *)
 
 (** Program and logical variables. *)

infer/src/IR/location.ml

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 module F = Format
 module L = Logging
 

infer/src/IR/location.mli

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Location in the original source file *)
 type t = {
   line: int; (** The line number. -1 means "do not know" *)

infer/src/IR/mangled.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for Mangled Names *)
 
 module F = Format

infer/src/IR/mangled.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for Mangled Names *)
 
 (** Type of mangled names *)

infer/src/IR/procAttributes.ml

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Attributes of a procedure. *)
 
 module L = Logging

infer/src/IR/procAttributes.mli

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Attributes of a procedure. *)
 
 type objc_accessor_type =

infer/src/IR/procname.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for Procedure Names *)
 
 module L = Logging

infer/src/IR/procname.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for Procedure Names. *)
 
 (** Type of java procedure names. *)

infer/src/IR/pvar.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** The Smallfoot Intermediate Language *)
 
 module L = Logging

infer/src/IR/pvar.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Program variables. *)
 
 module F = Format

infer/src/IR/sil.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** The Smallfoot Intermediate Language *)
 
 module L = Logging

infer/src/IR/sil.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** The Smallfoot Intermediate Language *)
 
 module F = Format

infer/src/IR/tenv.ml

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for Type Environments. *)
 
 (** Hash tables on strings. *)

infer/src/IR/tenv.mli

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for Type Environments. *)
 
 type t (** Type for type environment. *)

infer/src/IR/typename.ml

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 module F = Format
 
 (** Named types. *)

infer/src/IR/typename.mli

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Named types. *)
 type t =
   | TN_typedef of Mangled.t

infer/src/Makefile.in

@@ -40,7 +40,6 @@ OCAMLBUILD_OPTIONS = \
                      -cflags -strict-sequence \
                      -cflags -w,$(OCAML_FATAL_WARNINGS)-4-9-40-41-42-45-48-50 \
                      -tag-line "<*{clang/clang_ast_*,backend/jsonbug_*}>: warn(-27-32-35-39)" \
-                     -tag-line "not <**/{config,iList,utils}.*>: open(Utils)" \
                      -pkgs atdgen,extlib,oUnit,str,unix,yojson,zip
 
 ifeq (@ENABLE_OCAML_ANNOT@,yes)

infer/src/backend/DB.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Database of analysis results *)
 
 module F = Format

infer/src/backend/DB.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Database of analysis results *)
 
 (** {2 Filename} *)

infer/src/backend/abs.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Implementation of Abstraction Functions *)
 
 module L = Logging

infer/src/backend/abs.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Implementation of Abstraction Functions *)
 
 (** Abstraction rules discovered *)

infer/src/backend/absarray.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Abstraction for Arrays *)
 
 module L = Logging

infer/src/backend/absarray.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Abstraction for Arrays *)
 
 (** Apply array abstraction and check the result *)

infer/src/backend/autounit.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Generate unit tests automatically from specs *)
 
 module L = Logging

infer/src/backend/autounit.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Generate unit tests automatically from specs *)
 
 (** type of generated code *)

infer/src/backend/buckets.ml

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Classify bugs into buckets *)
 
 module L = Logging

infer/src/backend/buckets.mli

@@ -8,6 +8,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Classify bugs into buckets *)
 
 (** Classify the bucket of an error desc using Location.access and nullable information *)

infer/src/backend/builtin.ml

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for builtin functions with their symbolic execution handler *)
 
 type args = {

infer/src/backend/builtin.mli

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module for builtin functions with their symbolic execution handler *)
 
 type args = {

infer/src/backend/callbacks.ml

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 module L = Logging
 
 (** Module to register and invoke callbacks *)

infer/src/backend/callbacks.mli

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 (** Module to register and invoke callbacks *)
 
 type proc_callback_args = {

infer/src/backend/cluster.ml

@@ -7,6 +7,8 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
+open! Utils
+
 module L = Logging
 module F = Format