forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Consolidate tips on CONTRIBUTING.md, and reduce the wall of text when opening a new issue. Hoping this will encourage more people to read through the text. Closes facebook#14518 Differential Revision: D5250443 Pulled By: hramos fbshipit-source-id: 91213c4ceca12225d9f54d1e1e81e020c6e463b3
- Loading branch information
1 parent
879edf0
commit 0d3b7fe
Showing
4 changed files
with
80 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,18 @@ | ||
Thanks for submitting a PR! Please read these instructions carefully: | ||
<details> | ||
Thanks for submitting a PR! Please read these instructions carefully: | ||
|
||
- [ ] Explain the **motivation** for making this change. | ||
- [ ] Provide a **test plan** demonstrating that the code is solid. | ||
- [ ] Match the **code formatting** of the rest of the codebase. | ||
- [ ] Target the `master` branch, NOT a "stable" branch. | ||
- [ ] Explain the **motivation** for making this change. | ||
- [ ] Provide a **test plan** demonstrating that the code is solid. | ||
- [ ] Match the **code formatting** of the rest of the codebase. | ||
- [ ] Target the `master` branch, NOT a "stable" branch. | ||
|
||
Please read the [Contribution Guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md) to learn more about contributing to React Native. | ||
</details> | ||
|
||
## Motivation (required) | ||
|
||
What existing problem does the pull request solve? | ||
_What existing problem does the pull request solve?_ | ||
|
||
## Test Plan (required) | ||
|
||
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. | ||
|
||
If you have added code that should be tested, add tests. | ||
|
||
## Next Steps | ||
|
||
Sign the [CLA][2], if you haven't already. | ||
|
||
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. | ||
|
||
Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. | ||
|
||
For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines. | ||
|
||
[1]: https://medium.com/@martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9 | ||
[2]: https://code.facebook.com/cla | ||
[3]: https://travis-ci.org/facebook/react-native | ||
[4]: http://circleci.com/gh/facebook/react-native | ||
[5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests | ||
_A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website._ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters