Skip to content

Commit

Permalink
Add Python 3.7 compatibility (spotify#2466)
Browse files Browse the repository at this point in the history
* Add tox python 3.7

* Mimic travis 3.6 setup for 3.7-dev to check for support

* Update travis to 3.7 (not dev) which currently requires xenial os distro

* Add explicit postgresql service to Travis

* Update 3.7 builds to override dist and sudo

* Add py37 to README support

* Update package classifiers for supported Python versions

* Remove python 3.4 and 3.5 from TravisCI testing

* Update readme python version support for tested versions
  • Loading branch information
dlstadther authored Sep 28, 2018
1 parent c151a5b commit 4389332
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 9 deletions.
23 changes: 16 additions & 7 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
language: python

dist: xenial

services:
- elasticsearch
- mysql
- docker
- postgresql

env:
global:
Expand All @@ -22,7 +25,6 @@ env:
- TOXENV=flake8
- TOXENV=docs
- TOXENV=py27-nonhdfs
- TOXENV=py34-nonhdfs
- TOXENV=py27-unixsocket
# - TOXENV=py27-cdh
# minicluster (cdh) tests disabled as lack of love, #2140.
Expand All @@ -33,18 +35,25 @@ env:
# - TOXENV=visualiser
# Disabling this test because of intermittent failures :-/

# Python 3.5 has to go here until Travis adds it to the default build images.
# https://github.com/travis-ci/travis-ci/issues/4794#issuecomment-143758799
sudo: false

# Python 3.7 needs to have its dist/sudo flags set in matrix so they don't
# break the other python builds.
# https://github.com/travis-ci/travis-ci/issues/9815
matrix:
include:
- python: 3.5
env: TOXENV=py35-nonhdfs
- python: 3.6
env: TOXENV=py36-nonhdfs
- python: 3.6
env: TOXENV=py36-unixsocket

sudo: false
- python: 3.7
dist: xenial
sudo: true
env: TOXENV=py37-nonhdfs
- python: 3.7
dist: xenial
sudo: true
env: TOXENV=py37-unixsocket

cache:
directories:
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
.. image:: https://img.shields.io/pypi/l/luigi.svg?style=flat
:target: https://pypi.python.org/pypi/luigi

Luigi is a Python (2.7, 3.3, 3.4, 3.5, 3.6) package that helps you build complex
Luigi is a Python (2.7, 3.6, 3.7 tested) package that helps you build complex
pipelines of batch jobs. It handles dependency resolution, workflow management,
visualization, handling failures, command line integration, and much more.

Expand Down
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ def get_static_files(path):
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Topic :: System :: Monitoring',
],
)
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py{27,33,34,35,36}-{cdh,hdp,nonhdfs,gcloud,postgres,unixsocket}, visualiser, pypy-scheduler, docs, flake8
envlist = py{27,33,34,35,36,37}-{cdh,hdp,nonhdfs,gcloud,postgres,unixsocket}, visualiser, pypy-scheduler, docs, flake8
skipsdist = True

[testenv]
Expand Down

0 comments on commit 4389332

Please sign in to comment.