Skip to content

Commit

Permalink
NEXT-36736 - Introduce rector/type-perfect PHPStan extension
Browse files Browse the repository at this point in the history
  • Loading branch information
mitelg committed Jun 19, 2024
1 parent 03aa6f5 commit 52320c4
Show file tree
Hide file tree
Showing 6 changed files with 107 additions and 111 deletions.
7 changes: 4 additions & 3 deletions .danger.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@
'^php$' => 'PHP does not follow semantic versioning, therefore minor updates include breaks',
],
'strict' => [
'^phpstan\/phpstan.*$' => 'Even patch updates for phpstan may lead to a red CI pipeline, because of new static analysis errors',
'^symplify\/phpstan-rules$' => 'Even patch updates for phpstan may lead to a red CI pipeline, because of new static analysis errors',
'^phpstan\/phpstan.*$' => 'Even patch updates for PHPStan may lead to a red CI pipeline, because of new static analysis errors',
'^symplify\/phpstan-rules$' => 'Even patch updates for PHPStan may lead to a red CI pipeline, because of new static analysis errors',
'^rector\/type-perfect$' => 'Even patch updates for PHPStan may lead to a red CI pipeline, because of new static analysis errors',
'^dompdf\/dompdf$' => 'Patch updates of dompdf have let to a lot of issues in the past, therefore it is pinned.',
'^scssphp\/scssphp$' => 'Patch updates of scssphp might lead to UI breaks, therefore it is pinned.',
'^shopware\/conflicts$' => 'The shopware conflicts packages should be required in any version, so use `*` constraint',
Expand Down Expand Up @@ -119,7 +120,7 @@ function (Context $context): void {

if ($filesWithIgnoredErrors) {
$context->failure(
'Some files you touched in your MR contain ignored phpstan errors. Please be nice and fix all ignored errors for the following files:<br>'
'Some files you touched in your MR contain ignored PHPStan errors. Please be nice and fix all ignored errors for the following files:<br>'
. implode('<br>', $filesWithIgnoredErrors)
);
}
Expand Down
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@
"phpstan/phpstan-symfony": "1.4.4",
"phpunit/phpunit": "^10.5",
"predis/predis": "^2.2",
"rector/type-perfect": "0.1.6",
"shopware/dev-tools": "^1.3",
"smalot/pdfparser": "^2.2.2",
"symfony/browser-kit": "~7.1.1",
Expand Down
Loading

0 comments on commit 52320c4

Please sign in to comment.