NEXT-36102 - Fix cms product slider

pweyck · Jul 30, 2024 · 6c39fa1 · 6c39fa1
1 parent fa64d77
commit 6c39fa1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/...07-29-fix-product-slider-not-displaying-products-from-dynamic-product-groups.md b/...07-29-fix-product-slider-not-displaying-products-from-dynamic-product-groups.md
@@ -0,0 +1,7 @@
+---
+title: Fix product slider not displaying products from dynamic product groups
+issue: NEXT-36102
+author: Lukas Rump
+---
+# Core
+* Changed `Shopware\Core\Content\Product\Cms\ProductSliderCmsElementResolver::handleProductStream` to add products with empty variant config.
diff --git a/src/Core/Content/Product/Cms/ProductSliderCmsElementResolver.php b/src/Core/Content/Product/Cms/ProductSliderCmsElementResolver.php
@@ -234,7 +234,7 @@ private function handleProductStream(ProductCollection $streamResult): ProductCo
         foreach ($streamResult as $product) {
             $variantConfig = $product->getVariantListingConfig();
 
-            if (!$variantConfig) {
+            if (!$variantConfig || ($variantConfig->getMainVariantId() === null && $variantConfig->getDisplayParent() === null)) {
                 $finalProducts->add($product);
                 continue;
             }

diff --git a/tests/unit/Core/Content/Product/Cms/ProductSliderCmsElementResolverTest.php b/tests/unit/Core/Content/Product/Cms/ProductSliderCmsElementResolverTest.php
@@ -518,6 +518,13 @@ public static function streamProductDataProvider(): \Generator
                 self::createProduct($parentId, null, new VariantListingConfig(false, $nonExistentId, [])),
             ],
         ];
+
+        yield 'empty variantListingConfig' => [
+            'expectedProductIds' => [$parentId],
+            'streamProducts' => [
+                self::createProduct($parentId, null, new VariantListingConfig(null, null, [])),
+            ],
+        ];
     }
 
     private static function createProduct(string $id, ?string $parentId, ?VariantListingConfig $config = null): SalesChannelProductEntity