NEXT-15827 - fixed broken search in sw-promotion-v2-sales-channel-sel…

…ect.html.twig
pweyck · Oct 21, 2021 · d12cd43 · d12cd43
1 parent edfb14b
commit d12cd43
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/...-10-21-fixed-broken-search-in-sw-promotion-v2-sales-channel-select.html.twig.md b/...-10-21-fixed-broken-search-in-sw-promotion-v2-sales-channel-select.html.twig.md
@@ -0,0 +1,9 @@
+---
+title: Fixed broken search in sw-promotion-v2-sales-channel-select.html.twig
+issue: NEXT-15827
+author: Marcel Hakvoort
+author_email: [email protected]
+author_github: @celha
+---
+# Administration
+* Fixed the broken `sw-multi-select` search in the `sw-promotion-v2-sales-channel-select.html.twig` component
diff --git a/...ration/src/module/sw-promotion-v2/component/sw-promotion-v2-sales-channel-select/index.js b/...ration/src/module/sw-promotion-v2/component/sw-promotion-v2-sales-channel-select/index.js
@@ -21,6 +21,7 @@ Component.register('sw-promotion-v2-sales-channel-select', {
     data() {
         return {
             salesChannels: [],
+            sortBy: 'name',
         };
     },
 
@@ -63,6 +64,13 @@ Component.register('sw-promotion-v2-sales-channel-select', {
                 this.handleWithRepository(deleted, added);
             },
         },
+
+        salesChannelCriteria() {
+            const salesChannelCriteria = new Criteria(1, 500);
+            salesChannelCriteria.addSorting(Criteria.sort(this.sortBy, this.sortDirection, this.naturalSorting));
+
+            return salesChannelCriteria;
+        },
     },
 
     created() {
@@ -72,7 +80,7 @@ Component.register('sw-promotion-v2-sales-channel-select', {
     methods: {
         createdComponent() {
             this.salesChannelRepository
-                .search(new Criteria(1, 500))
+                .search(this.salesChannelCriteria)
                 .then(searchresult => {
                     this.salesChannels = searchresult;
                 });

diff --git a/...onent/sw-promotion-v2-sales-channel-select/sw-promotion-v2-sales-channel-select.html.twig b/...onent/sw-promotion-v2-sales-channel-select/sw-promotion-v2-sales-channel-select.html.twig
@@ -4,6 +4,7 @@
     v-bind="$attrs"
     :options="salesChannels"
     value-property="id"
+    label-property="name"
 >
 
     {% block sw_promotion_v2_sales_channel_selection_label %}